Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 1, 2020

This fixes the following ugly crash when trying to use --easystack without having PyYAML installed (which is a problem I introduced with the commits I added to #3479 before merging it), and also improves the @only_if_module_is_available decorator a bit (which was the underlying cause of the trouble).

closes #3514

@boegel boegel added the bug fix label Dec 1, 2020
@boegel boegel added this to the 4.3.2 (next release) milestone Dec 1, 2020
@migueldiascosta
Copy link
Member

confirm that it fixes #3514 (the yaml requirement is now clear with both python 2 and 3)

migueldiascosta
migueldiascosta previously approved these changes Dec 1, 2020
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoldeman bartoldeman merged commit 0fd5613 into easybuilders:develop Dec 1, 2020
@boegel boegel deleted the fix_easystack_yaml_check branch December 1, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

easystack tests in test/framework/option.py fail when PyYAML is not installed

3 participants