Skip to content

tweak test_easystack_basic to get better error reporting if it fails #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
migueldiascosta merged 2 commits into from
Dec 1, 2020
Merged

tweak test_easystack_basic to get better error reporting if it fails #3511

migueldiascosta merged 2 commits into from
Dec 1, 2020

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 1, 2020

No description provided.

@boegel boegel added the bug fix label Dec 1, 2020
@boegel boegel added this to the 4.3.2 (next release) milestone Dec 1, 2020
@migueldiascosta
Copy link
Member

migueldiascosta commented Dec 1, 2020

@boegel this will still not show the actual error, maybe first check that err is empty and print it if it is not?

migueldiascosta
migueldiascosta approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@migueldiascosta migueldiascosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@migueldiascosta
Copy link
Member

migueldiascosta commented Dec 1, 2020

Going in, thanks @boegel!

@migueldiascosta migueldiascosta merged commit dea39f5 into easybuilders:develop Dec 1, 2020
@boegel boegel deleted the fix_easystack_tests branch December 1, 2020 09:54
@migueldiascosta migueldiascosta mentioned this pull request Dec 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@migueldiascosta migueldiascosta migueldiascosta approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.3.2

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @migueldiascosta