Skip to content

avoid TypeError being raised by list_toolchains #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartoldeman merged 2 commits into from
Nov 9, 2020
Merged

avoid TypeError being raised by list_toolchains #3499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69ab582
avoid TypeError being raised by list_toolchains
boegel Nov 9, 2020
ab4aa6f
clean up implementation in list_toolchain functions
boegel Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions easybuild/tools/docs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,16 +726,16 @@ def list_software_txt(software, detailed=False):
def list_toolchains(output_format=FORMAT_TXT):
"""Show list of known toolchains."""
_, all_tcs = search_toolchain('')
all_tcs_names = [x.NAME for x in all_tcs]
tclist = sorted(zip(all_tcs_names, all_tcs))

tcs = dict()
for (tcname, tcc) in tclist:
# filter deprecated 'dummy' toolchain
all_tcs = [x for x in all_tcs if x.NAME != DUMMY_TOOLCHAIN_NAME]
all_tcs_names = [x.NAME for x in all_tcs]

# filter deprecated 'dummy' toolchain
if tcname == DUMMY_TOOLCHAIN_NAME:
continue
# start with dict that maps toolchain name to corresponding subclass of Toolchain
tcs = dict(zip(all_tcs_names, all_tcs))

for tcname in sorted(tcs):
tcc = tcs[tcname]
tc = tcc(version='1.2.3') # version doesn't matter here, but something needs to be there
tcs[tcname] = tc.definition()

Expand Down