Skip to content

allow copying of tweaked easyconfigs when using --try-* with --copy-ec #3332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 11 commits into from
May 19, 2020
Merged

allow copying of tweaked easyconfigs when using --try-* with --copy-ec #3332

boegel merged 11 commits into from
May 19, 2020

Conversation

@ocaisa
Copy link
Member

@ocaisa ocaisa commented May 8, 2020 •
edited by boegel
Loading

Requires #3330

Example usage:

eb --experimental --copy-ec --dry-run --robot --try-toolchain=foss,2019a --minimal-toolchains --try-update-deps --try-software-version=2.2.5 Keras-2.2.4-foss-2018b-Python-3.6.6.eb my_copy_of_tweaked_ecs

This will only copy the tweaked easyconfigs that are (or would be) actually used to resolve dependencies.

@ocaisa ocaisa mentioned this pull request May 8, 2020
Closed
@ocaisa ocaisa changed the title Allow dumping of tweaked easyconfigs when using --try-* Allow copying of tweaked easyconfigs when using --try-* May 8, 2020
@easybuilders easybuilders deleted a comment from boegelbot May 12, 2020
@mboisson
Copy link
Contributor

mboisson commented May 12, 2020

@ocaisa, this does not call clean_up_easyconfigs. Is it possible to add this ?

@ocaisa
Copy link
Member Author

ocaisa commented May 12, 2020

I don't know what that is yet...but yes

@mboisson
Copy link
Contributor

mboisson commented May 12, 2020

easybuild-framework/easybuild/framework/easyconfig/easyconfig.py

Line 2250 in 018337e

def clean_up_easyconfigs(paths):

@boegel boegel added this to the next release (4.2.1?) milestone May 13, 2020
boegel
boegel approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel changed the title Allow copying of tweaked easyconfigs when using --try-* allow copying of tweaked easyconfigs when using --try-* with --copy-ec May 19, 2020
@boegel boegel merged commit b51aceb into easybuilders:develop May 19, 2020
@ocaisa ocaisa deleted the dump_tweaked_easyconfigs branch May 19, 2020 11:33
@migueldiascosta migueldiascosta mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@ocaisa @mboisson @boegel