Skip to content

make pypi_source_urls more robust by using HTMLParser rather than xml.etree.ElementTree #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Micket merged 1 commit into from
May 7, 2020
Merged

make pypi_source_urls more robust by using HTMLParser rather than xml.etree.ElementTree #3329

Micket merged 1 commit into from
May 7, 2020

Conversation

@boegel
Copy link
Member

@boegel boegel commented May 7, 2020

fixes #3327

@boegel boegel added this to the next release (4.2.1?) milestone May 7, 2020
Micket
Micket approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 6343ea2 into easybuilders:develop May 7, 2020
@boegel boegel mentioned this pull request May 7, 2020
Closed
@boegel boegel deleted the more_robust_pypi_source_urls branch May 8, 2020 05:46
@boegel boegel mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.2.1

Development

Successfully merging this pull request may close these issues.

stop relying on xml.etree.ElementTree to parse HTML served by PyPI's /simple API

2 participants

@boegel @Micket