Only calculate the mapping of version suffixes if they are actually used #3326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Asking for @ocaisa's review of this PR. |
ocaisa
requested changes
May 6, 2020
Member
ocaisa
left a comment
ocaisa
left a comment
There was a problem hiding this comment.
Lgtm apart from those comments
Member
|
See ComputeCanada#23 to improve the error reporting that triggered this PR |
Make error for version suffix mapping more explicit
Contributor
Author
merged. |
ocaisa
approved these changes
May 7, 2020
Member
|
Going in as soon as the tests pass, thanks @mboisson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, at our site, when using multiple paths in
EASYBUILD_ROBOT_PATHS, this fails withERROR: No unique versionsuffix mapping for -Python-2.7.10 in {'name': 'GCC', 'version': '7.3.0'} toolchain hierarchy to {'name': 'GCC', 'version': '9.3.0'} toolchain hierarchyWhile this may or may not be a bug in the easyconfigs we have in our robot_paths (we may have duplicated -Python version suffixes for example), we don't usually use versionsuffixes, and for the easyconfig I was trying to build, there are absolutely no need to have
versionsuffixmapped, since none is used.