also mention CPU architecture (x86_64, POWER) in comment for test reports #3281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
to be fair, |
Contributor
Author
|
Which is still to be installed manually. Our site doesn't and the boostraped and EB installed modules don't contain it either. (And I personally wasn't even aware of its existance until recently) Anything wrong with this PR? IMO It is simple and a good improvement. Especially because it shows a variable which changes behavior of EasyBlocks. The archspec output doesn't. |
Contributor
|
As I said I don't mind adding this change, but I'll leave the decision to someone else (@boegel ?) |
boegel
changed the title
boegel
approved these changes
Apr 18, 2020
Member
boegel
left a comment
boegel
left a comment
There was a problem hiding this comment.
makes perfect sense, thanks @Flamefire!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In easybuilders/easybuild-easyconfigs#9830 I noted that the architecture is now included in the test report, so it's hard to tell which reports are from x86 and which are from power.
Yes there is CPU model stuff via archspec, but that needs an (undocumented?) external dependency.
This PR uses the already available
get_cpu_architecturewhich is also used in various EasyBlocks to change behavior and adds it to the report.Example: easybuilders/easybuild-easyconfigs#10397 (comment)
and