Refactor mpi_cmd_for so we can just grab an MPI execution command

[ocaisa]

No description provided.

[ocaisa]

@boegel I've set this up so that it could be templated in an easyconfig but to do that I would need a toolchain instance for the easyconfig since I would rely on knowing the MPI family. Not sure where to do that though

[boegel]

Do we really need a separate configuration setting?

We can just replace %(cmd)s with an empty string whenever we need just the mpirun ... bit without the trailing command?

[boegel]

@boegel I've set this up so that it could be templated in an easyconfig but to do that I would need a toolchain instance for the easyconfig since I would rely on knowing the MPI family. Not sure where to do that though

template values are collected via template_constant_dict, which is called from EasyConfig._generate_template_values.

You can pass down the toolchain instance from the EasyConfig instance down to template_constant_dict and put it to good use there, something like this:

template_values = template_constant_dict(self, ignore=ignore, toolchain=self.toolchain)

and then in template_constant_dict:

def template_constant_dict(..., toolchain=None):
    ...
    if toolchain is not None and hasattr(toolchain, 'mpi_cmd_for'):
        # use empty string as command, to only get prefix for commands to be run with mpirun
        mpi_cmd_prefix = toolchain.mpi_cmd_for('', 1)
        template_values['mpi_cmd_prefix'] = mpi_cmd_prefix
       
    

[ocaisa]

template values are collected via template_constant_dict, which is called from EasyConfig._generate_template_values.

You can pass down the toolchain instance from the EasyConfig instance down to template_constant_dict and put it to good use there, something like this:

template_values = template_constant_dict(self, ignore=ignore, toolchain=self.toolchain)

and then in template_constant_dict:

def template_constant_dict(..., toolchain=None):
    ...
    if toolchain is not None and hasattr(toolchain, 'mpi_cmd_for'):
        # use empty string as command, to only get prefix for commands to be run with mpirun
        mpi_cmd_prefix = toolchain.mpi_cmd_for('', 1)
        template_values['mpi_cmd_prefix'] = mpi_cmd_prefix
       
    

I could have done this without making any other changes...I think I might just replace this PR rather than row back all the other changes.

[ocaisa]

Closed in favour of #3264