Skip to content

advise PR labels in --review-pr and add support for --add-pr-labels #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 32 commits into from
Feb 19, 2021
Merged

advise PR labels in --review-pr and add support for --add-pr-labels #3177

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
e30df76
advise pr labels in --review-pr
migueldiascosta Jan 27, 2020
0eb57e9
compare with actual PR labels
migueldiascosta Feb 18, 2020
0e5beaf
try to set missing labels
migueldiascosta Feb 19, 2020
1b990bb
remove unnecessary decorator and don't raise error if github user or …
migueldiascosta Mar 30, 2020
97e6644
flesh out code to determine labels into separate function
migueldiascosta Apr 8, 2020
24207e8
revert posting labels in --review-pr
migueldiascosta Apr 8, 2020
430cbe5
also consider easyblocks in new det_labels function
migueldiascosta Apr 8, 2020
6c3a435
Merge branch 'develop' into review_pr_labels
migueldiascosta Apr 8, 2020
7ab4be8
add missing import
migueldiascosta Apr 8, 2020
f537040
Merge branch 'review_pr_labels' of github.com:migueldiascosta/easybui…
migueldiascosta Apr 8, 2020
4138715
move det_labels to github.py
migueldiascosta Apr 8, 2020
947fb72
fix wrong indentation
migueldiascosta Apr 9, 2020
056dd34
get correct pr_target_repo for review_pr and exit if it is not easyco…
migueldiascosta Apr 9, 2020
e23f00c
also test for label advice in test_review_pr
migueldiascosta Apr 9, 2020
ace7b59
add test for det_labels
migueldiascosta Apr 9, 2020
ed887fe
appease the hound
migueldiascosta Apr 9, 2020
ca66c6d
Merge branch 'develop' into review_pr_labels
migueldiascosta Apr 9, 2020
3d32296
cleanup code
migueldiascosta Apr 11, 2020
88c6d14
ignore PR labels when testing --review-pr label suggestions
migueldiascosta Apr 12, 2020
ef3979e
add support for --add-pr-labels
migueldiascosta Apr 12, 2020
229c391
Merge branch 'develop' of github.com:easybuilders/easybuild-framework…
migueldiascosta Apr 12, 2020
5155d2f
Merge branch 'develop' into review_pr_labels
boegel May 19, 2020
42f59bb
sync with develop
migueldiascosta Sep 14, 2020
043e65c
add test for add_pr_labels
migueldiascosta Sep 14, 2020
8b761d0
fix conflict
migueldiascosta Sep 14, 2020
31bd938
fix ambiguous variable name
migueldiascosta Sep 14, 2020
d9f272a
fix test for add_pr_labels
migueldiascosta Sep 16, 2020
3d4fc64
add new sandboxed easyblocks to test_list_easyblocks
migueldiascosta Sep 16, 2020
c89e672
Merge branch 'develop' into review_pr_labels
migueldiascosta Oct 14, 2020
ca1d9c3
Merge branch 'develop' into review_pr_labels
migueldiascosta Dec 1, 2020
83662ac
Merge branch 'develop' into review_pr_labels
migueldiascosta Dec 1, 2020
5c3a069
Merge branch 'develop' into review_pr_labels
boegel Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion easybuild/framework/easyconfig/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
from easybuild.base import fancylogger
from easybuild.framework.easyconfig import EASYCONFIGS_PKG_SUBDIR
from easybuild.framework.easyconfig.easyconfig import EASYCONFIGS_ARCHIVE_DIR, ActiveMNS, EasyConfig
from easybuild.framework.easyconfig.easyconfig import create_paths, get_easyblock_class, process_easyconfig
from easybuild.framework.easyconfig.easyconfig import create_paths, det_file_info, get_easyblock_class
from easybuild.framework.easyconfig.easyconfig import process_easyconfig
from easybuild.framework.easyconfig.format.yeb import quote_yaml_special_chars
from easybuild.framework.easyconfig.style import cmdline_easyconfigs_style_check
from easybuild.tools.build_log import EasyBuildError, print_msg, print_warning
Expand Down Expand Up @@ -538,6 +539,16 @@ def review_pr(paths=None, pr=None, colored=True, branch='develop'):
else:
lines.extend(['', "(no related easyconfigs found for %s)\n" % os.path.basename(ec['spec'])])

labels = []
file_info = det_file_info(pr_files, download_repo_path)
if any(file_info['new_folder']):
labels.append('new')
if any(file_info['new_file_in_existing_folder']):
labels.append('update')

if labels: # TODO: compare to actual PR labels?
lines.extend(['', "This PR should be labeled %s" % ', '.join(labels)])

return '\n'.join(lines)


Expand Down