Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Apr 2, 2019

@vanzod Please merge ASAP, since this is making the easyconfig tests fail after easybuilders/easybuild-easyconfigs#7921 got merged.

I'll follow up later with a dedicated test for this bug.

This problem was introduced in #2813, and makes --check-conflicts fail as soon as an easyconfig file that uses multi_deps is picked up, for example:

eb --check-conflicts SciPy-bundle-2019.03-foss-2019a.eb
== temporary log file in case of crash /tmp/eb-K0_31k/easybuild-jpxQWc.log
Traceback (most recent call last):
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/Volumes/work/easybuild-framework/easybuild/main.py", line 454, in <module>
    main()
  File "/Volumes/work/easybuild-framework/easybuild/main.py", line 386, in main
    if check_conflicts(easyconfigs, modtool):
  File "/Volumes/work/easybuild-framework/easybuild/tools/robot.py", line 123, in check_conflicts
    build_deps = mk_dep_keys(node['builddependencies'])
  File "/Volumes/work/easybuild-framework/easybuild/tools/robot.py", line 109, in mk_dep_keys
    if not dep.get('external_module', False):
AttributeError: 'list' object has no attribute 'get'

@vanzod vanzod merged commit fa2179b into easybuilders:develop Apr 2, 2019
@boegel boegel deleted the fix_check_conflicts_multi_deps branch April 2, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants