Skip to content

stick to idna<2.8 with Python 2.6 in Travis + distable broken test for HgRepository #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akesandgren merged 2 commits into from
Dec 5, 2018
Merged

stick to idna<2.8 with Python 2.6 in Travis + distable broken test for HgRepository #2678

akesandgren merged 2 commits into from
Dec 5, 2018

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 4, 2018

No description provided.

@boegel boegel added the bug fix label Dec 4, 2018
@boegel boegel added this to the 3.8.0 milestone Dec 4, 2018
@boegel boegel requested a review from vanzod December 4, 2018 21:31
vanzod
vanzod previously approved these changes Dec 4, 2018
View reviewed changes
@boegel
Copy link
Member Author

boegel commented Dec 5, 2018 •
edited
Loading

HgRepo test failes because of:

WARNING: Mercurial local repo initialization failed, it might already exist: (255, '', 'warning: connecting to bitbucket.org using legacy security technology (TLS 1.0); see https://mercurial-scm.org/wiki/SecureConnections for more info\nabort: error: _ssl.c:510: error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number')

@boegel
Copy link
Member Author

boegel commented Dec 5, 2018 •
edited
Loading

That test fails because of bitbucket.org disabling TLS 1.0/1.1 (see https://bitbucket.org/blog/deprecating-tlsv1-tlsv1-1-2018-12-01), while Python 2.6 doesn't support newer TLS versions.

That's a blocker for the test_hgrepo test, I see no other way to disable that test for now until we've dropped support for Python 2.6...

@boegel boegel changed the title stick to idna<2.8 with Python 2.6 in Travis stick to idna<2.8 with Python 2.6 in Travis + distable broken test for HgRepository Dec 5, 2018
akesandgren
akesandgren approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren akesandgren merged commit 470f9be into easybuilders:develop Dec 5, 2018
@boegel boegel deleted the fix_travis branch December 5, 2018 10:00
@boegel boegel mentioned this pull request Dec 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

@vanzod vanzod vanzod left review comments

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @akesandgren @vanzod