add support for --list-prs #2400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Feb 13, 2018
easybuild/tools/options.py
Outdated
| 'list-prs': ("List pull requests", None, 'store_true', None), | ||
| 'list-prs-state': ("List pull requests in state open/closed", str, 'store', 'open'), | ||
| 'list-prs-sort': ("Sort pull requests by created/updated/popularity", str, 'store', 'created'), | ||
| 'list-prs-direction': ("Sorting pull requests in asc/desc order", str, 'store', 'desc'), |
Member
There was a problem hiding this comment.
Also choice option? Maybe list-prs-order is better?
easybuild/tools/github.py
Outdated
| """ | ||
| List PRs | ||
| :param parameters: https://developer.github.com/v3/pulls/#parameters |
Member
There was a problem hiding this comment.
Selection parameters for PRs, see https://developer.github.com/v3/pulls/#parameters
Member
|
@migueldiascosta Can you look into adding a test too? |
Member
Author
|
@boegel using the actual PRs as expected output? Hm, I suppose the output of list_prs({'direction': 'asc', 'sort': 'created', 'state': 'closed'})should be constant... |
Member
Author
|
ah, the tests use I'll submit and close a PR to it so it can be tested. |
boegel
reviewed
Mar 14, 2018
boegel
requested changes
Mar 14, 2018
boegel
requested changes
Mar 20, 2018
test/framework/github.py
Outdated
| expected = "PR #1: a pr" | ||
|
|
||
| try: | ||
| output = gh.list_prs(parameters) |
Member
There was a problem hiding this comment.
Given all the parsing magic we have, I would test --list-prs directly via a test in test/framework/options.py?
migueldiascosta
changed the title
migueldiascosta
changed the title
…r message for --list-prs
boegel
changed the title
use constants for open/created/desc + mention incorrect value in error message for --list-prs
houndci-bot
reviewed
Nov 20, 2018
This was referenced Nov 20, 2018
appease the Hound
…ITHUB_MAX_PER_PAGE from _postprocess_list_prs
ensure ordered output in message printed by --list-prs, drop unused GITHUB_MAX_PER_PAGE from _postprocess_list_prs
houndci-bot
reviewed
Nov 22, 2018
houndci-bot
reviewed
Nov 22, 2018
boegel
approved these changes
Nov 22, 2018
Member
|
Thanks @migueldiascosta! |
migueldiascosta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.