Skip to content

Added wrappers for shutil.copytree and os.chdir (WIP)#1561

Closed
wpoely86 wants to merge 7 commits intoeasybuilders:developfrom
wpoely86:wrappers
Closed

Added wrappers for shutil.copytree and os.chdir (WIP)#1561
wpoely86 wants to merge 7 commits intoeasybuilders:developfrom
wpoely86:wrappers

Conversation

@wpoely86
Copy link
Member

To be used for the extended dry run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include DEPRECATED in the docstring please

@hpcugentbot
Copy link

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2547/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Member Author

@boegel an attempt at including files, still needs proper testing

@hpcugentbot
Copy link

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2548/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel boegel changed the title Added wrappers for shutil.copytree and os.chdir Added wrappers for shutil.copytree and os.chdir (WIP) Jan 21, 2016
@boegel
Copy link
Member

boegel commented Jan 21, 2016

@wpoely86: keep me posted if you'v tested this through; are you up for adding tests for these too?

@hpcugentbot
Copy link

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2549/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2550/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

EasyBuild framework unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-framework-pr-builder/2562/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Jan 23, 2016

@wpoely86: please take into account easybuilders/easybuild-easyblocks#492 here

@boegel boegel modified the milestone: v2.7.0 Jan 23, 2016
@boegel boegel modified the milestones: v2.7.0, v2.8.0 Mar 9, 2016
@boegel boegel modified the milestones: v2.8.0, v2.x May 10, 2016
@boegel boegel modified the milestones: v2.x, v2.8.0 May 10, 2016
for item in src:
if os.path.isfile(item):
_log.debug("Copying file %s to %s" % (item, dst))
shutil.copy2(item, dst)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should take into account that individual files can also be symlinks, since copy2 resolves the symlink rather than copying it

cfr. http://stackoverflow.com/questions/4847615/copying-a-symbolic-link-in-python

@boegel boegel modified the milestones: 3.x, 4.x Feb 20, 2020
@wpoely86
Copy link
Member Author

This is going to stay WIP forever

@wpoely86 wpoely86 closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants