Skip to content

Conversation

@Helios07
Copy link

@Helios07 Helios07 commented Apr 4, 2019

(created using eb --new-pr)

Note: this PR is used in the tests for --add-pr-labels (see framework PR #3177), so don't add labels to this PR!

@akesandgren
Copy link
Contributor

I think we should go with #7697 instead

@boegelbot
Copy link
Collaborator

Travis test report: 2/2 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/515596855

Only showing partial log for 1st failed test suite run 14035.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/515596856

...
FAIL: Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 61, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 1

----------------------------------------------------------------------
Ran 10950 tests in 977.360s

FAILED (failures=1)
ERROR: Not all tests were successful.

*bleep, bloop, I'm just a bot (boegelbot v20180813.01)*Please talk to my owner @boegel if you notice you me acting stupid),or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@migueldiascosta
Copy link
Member

@Helios07 the error comes from #prebuildopts which needs a space after # (you can check style yourself with --check-contrib), but do check if #7697 works for you

@Helios07 Helios07 closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants