{lang}[dummy/dummy] IntelPython v2.7.15, IntelPython v3.6.8 #7920
Conversation
|
OK... working on checksums.... --check-style really should catch this before I upload. |
hi, |
|
re: --check-contrib??? are there any more arcane --check commands I should know about? why is check-contrib more rigorous than check-style and why are there two options to do basically the same thing? How do they differ? |
|
@JackPerdue We felt that checking for SHA256 checksums didn't belong under |
| buildininstalldir = True | ||
|
|
||
| preinstallopts = """ | ||
| echo -e "install:\n\t./setup_intel_python.sh" > Makefile |
There was a problem hiding this comment.
@JackPerdue It looks like this could be handled via the Binary easyblock as well, by specifying install_cmd?
| Accelerating Python* performance on modern architectures from Intel. | ||
| """ | ||
|
|
||
| # l_pythoni2_p_2019.2.066.tar.gz from the Intel site |
There was a problem hiding this comment.
@JackPerdue We can actually include the source_urls imho, since Intel allows you to simply curl them without authorization (and I was told they're not planning to change this).
We already do this for recent icc, ifort, impi, imkl versions too (and so do other projects).
|
re: --check-style vs. --check-contrib.... to me just adds confusion... the only time I really care about EB's style is when I want to contribute upstream to EB.... why not just make them one command and just put out a warning if the checksum is missing? And while on the subject of code checks for PRs.... does EB yet have a tool that will allow users to check the order of their easyconfigs. e.g. easyblock, name, version, versionsuffix, toolchain, toolchainopts, source_urls[1], sources, builddependencies[2], dependencies, ......, moduleclass). There was talk of such a feature at one point. It would be nice if it could be merged into --check-contrib (while just dropping or aliasing --check-style) |
|
s/versionsuffix, toolchain/versionsuffix, homepage, description, toolchain/ |
| Accelerating Python* performance on modern architectures from Intel. | ||
| """ | ||
|
|
||
| source_urls = ['http://registrationcenter-download.intel.com/akdlm/irc_nas/tec/15293/'] |
There was a problem hiding this comment.
@JackPerdue This is the download URL for 2019 update 3, should be .../15115/?
There was a problem hiding this comment.
Okay... just made a guess based on our Intel account... if you say 15115 then I'll do that
|
@JackPerdue W.r.t. also checking order of easyconfig parameter, I started working on it a while ago, but didn't manage to finish it (yet), see easybuilders/easybuild-framework#2165 |
|
Test report by @boegel |
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @JackPerdue! |
4 participants
(created using
eb --new-pr)