Skip to content

{vis}[foss/2017b] OpenCV v3.3.0, GTK+ v2.24.32, ATK v2.27.1, ... #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wpoely86 merged 2 commits into from
Feb 24, 2018
Merged

{vis}[foss/2017b] OpenCV v3.3.0, GTK+ v2.24.32, ATK v2.27.1, ... #5813

wpoely86 merged 2 commits into from
Feb 24, 2018

Conversation

@boegel
Copy link
Member

@boegel boegel commented Feb 12, 2018

(created using eb --new-pr)

@boegel
adding easyconfigs: OpenCV-3.3.0-foss-2017b-Python-3.6.3.eb, GTK+-2.2…
1b25ac2 
…4.32-foss-2017b.eb, ATK-2.27.1-foss-2017b.eb, Gdk-Pixbuf-2.36.11-foss-2017b.eb, Pango-1.41.0-foss-2017b.eb
@boegel boegel added the update label Feb 12, 2018
@boegel boegel added this to the next release (3.5.2 or 3.6.0) milestone Feb 12, 2018
verdurin
verdurin reviewed Feb 12, 2018
View reviewed changes
easybuild/easyconfigs/a/ATK/ATK-2.27.1-foss-2017b.eb Outdated

builddependencies = [
('GObject-Introspection', '1.53.5', '-Python-2.7.14'),
]
Copy link
Member

@verdurin verdurin Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel - perhaps one for the style checker in future is whether to have (as I prefer) a line in between builddependencies and dependencies. It's not consistent in this PR.

Copy link
Member Author

@boegel boegel Feb 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would certainly help making things more consistent.

A bigger one is checking the order of easyconfig parameters though, see easybuilders/easybuild-framework#2165

@boegel
Copy link
Member Author

boegel commented Feb 13, 2018 •
edited
Loading

Test report by @boegel
FAILED
Build succeeded for 4 out of 5 (5 easyconfigs in this PR)
node2444.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/bb49df1aab12fc20d681887e6e49d99e for a full test report.

edit: OpenCV build procedure finds ccache, but can't cache in the default location because I've made it read-only on purpose... Will resubmit test reports without having ccache available.

@boegel
Copy link
Member Author

boegel commented Feb 13, 2018

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2441.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/e9628794605a100802589be6f1e3102a for a full test report.

@boegel
Copy link
Member Author

boegel commented Feb 13, 2018

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2035.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/86bf7f221e2e682946b6eb5dbba9dcdb for a full test report.

@boegel boegel mentioned this pull request Feb 13, 2018
Merged
@wpoely86 wpoely86 merged commit adc9900 into easybuilders:develop Feb 24, 2018
@boegel boegel deleted the 20180212133429_new_pr_OpenCV330 branch February 25, 2018 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin left review comments

@wpoely86 wpoely86 wpoely86 approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.5.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @verdurin @wpoely86