Skip to content

{devel}[Java] Bazel 0.4.4 #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boegel merged 3 commits into from
Feb 15, 2017
Merged

{devel}[Java] Bazel 0.4.4 #4114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcfcb50
update for non cray
rjeschmi Feb 9, 2017
c261e36
updating with review feedback
rjeschmi Feb 15, 2017
e076db3
update per review
rjeschmi Feb 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions easybuild/easyconfigs/b/Bazel/Bazel-0.4.4.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# @author: Robert Schmidt (OHRI)
# @author: Guilherme Peretti-Pezzi (CSCS)

easyblock = "CmdCp"

name = 'Bazel'
version = '0.4.4'

homepage = 'http://bazel.io/'
description = """Bazel is a build tool that builds code quickly and reliably.
It is used to build the majority of Google's software."""

toolchain = {'name': 'dummy', 'version': ''}

dependencies = [
('Java', '1.8.0_121'),
]
Copy link
Member

@boegel boegel Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this down, below source_urls


sources = ['%(namelower)s-%(version)s-dist.zip']
source_urls = ['https://github.com/bazelbuild/bazel/releases/download/%(version)s']
cmds_map = [('.*', "JAVA_VERSION=1.8 CC=gcc CXX=g++ ./compile.sh")]
Copy link
Contributor

@pforai pforai Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe set $CC to cc and $CXX to c++ in order to match to the implicit rules that GNU make has as well? Or not use dummy as TC but set it to some GCC core version? Just a suggestion ...

Copy link
Contributor Author

@rjeschmi rjeschmi Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know if I really need to set anything. I'll just remove it I think.

Copy link
Member

@boegel boegel Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave a blank line above cmds_map, and try to avoid hardcoding the Java version; you can use %(javashortver)s instead (cfr. http://easybuild.readthedocs.io/en/latest/version-specific/easyconfig_templates.html#template-names-values-for-short-software-versions)


files_to_copy = [(['output/bazel'], 'bin')]

sanity_check_paths={
'files': ['bin/bazel'],
'dirs': ['bin'],
Copy link
Contributor

@pforai pforai Feb 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the advantage would be to check for bin/foo and bin/ separately...

Copy link
Member

@boegel boegel Feb 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is useless if you're already checking for files in bin/, but fine :)

}

moduleclass = 'devel'
15 changes: 15 additions & 0 deletions easybuild/easyconfigs/j/Java/Java-1.8.0_121.eb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name = 'Java'
version = "1.8.0_121"

homepage = 'http://java.com/'
description = """Java Platform, Standard Edition (Java SE) lets you develop and deploy
Java applications on desktops and servers."""

toolchain = {'name': 'dummy', 'version': 'dummy'}

# download the tar.gz directly from http://www.oracle.com/technetwork/java/javase/downloads/index.html
(vp, vs) = version.split('_')
altver = '%su%s' % (vp.split('.')[1], vs)
sources = ['jdk-%s-linux-x64.tar.gz' % altver]

moduleclass = 'lang'