{bio}[foss/2024a] OrthoFinder v3.1.0, replace the bundled famsa#26137
{bio}[foss/2024a] OrthoFinder v3.1.0, replace the bundled famsa#26137wdlingit wants to merge 3 commits into
Conversation
|
Test report by @jfgrimm |
|
@boegelbot: please test @ jsc-zen3 |
|
@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 4592700248 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
@wdlingit what python version did you run easybuild with when you generated the checksum? older python versions don't give reproducible git checksums |
Co-authored-by: Jasper Grimm <65227842+jfgrimm@users.noreply.github.com>
|
@boegelbot: please test @ jsc-zen3 |
|
@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 4593017776 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
hmm, it looks like |
It seems that most of the dependent libraries were forked from some original versions. I am not sure whether they made individual customizations or not. The object file of mimalloc was used for making the binary (see below for the command from log). To be honest, I don't know how to apply EB dependencies for this situation. Could you please give me some idea? |
The current config of OrthoFinder 3.1.0 would use the bundled famsa binary, which might cause problem as mentioned in OrthoFinder/OrthoFinder#22 . This commit includes an EB file of FAMSA, adding dependency to FAMSA, and removing the bundled famsa (*).
*: it seems that OrthoFinder tries to use the bundled famsa first, no matter famsa is available in the environment or not.