Handle arch-specific dependencies in tests#25739
Merged
Merged
Conversation
When a dependency version depends on the architecture we currently only test the single one for the host the test is running on, likely x86. This makes tests fail when dependencies are removed as the parsed on dumped list of dependencies will have different lengths. Fix this by choosing another one, if possible. Additionally always pick a random version when there are multiple versions such that multiple CI runs are likely to test all variants.
Flamefire
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dependency version depends on the architecture we currently only test the single one for the host the test is running on, likely x86.
This makes tests fail when dependencies are removed as the parsed on dumped list of dependencies will have different lengths. Fix this by choosing another one, if possible.
Additionally always pick a random version when there are multiple versions such that multiple CI runs are likely to test all variants.
Alternative to #25737
Closes #25737