-
Notifications
You must be signed in to change notification settings - Fork 772
{bio}[foss/2025a] GROMACS v2025.2 #23566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[foss/2025a] GROMACS v2025.2 #23566
Conversation
Updated software
|
…cks/easybuild-easyconfigs into 20250802151556_new_pr_GROMACS20252
smoors
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for your contribution @absrocks !
| ('SciPy-bundle', '2025.06'), | ||
| ('networkx', '3.5'), | ||
| ('mpi4py', '4.1.0'), | ||
| ('pybind11', '2.13.6'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably a builddependency instead of a normal dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hijacking this thread, since I've built the same version for the potential 2025b:
== FAILED: Installation ended unsuccessfully: `/data/EasyBuild-develop/software/Python/3.13.5-GCCcore-14.3.0/bin/python -m pip check` failed:
gmxapi 0.4.2 requires pybind11, which is not installed.
So we need a hard-dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think it's needed.
in the gmxapi sources on pypi (which are used here) it is listed as an install dependency, but in gmxapi sources included in the GROMACS sources it is only listed as a build dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we might be able to work around this with a patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch added in #23699
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added patch from #23699 and added pybind in builddependency
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 3271250568 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @Crivella |
|
Test report by @boegelbot |
Crivella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Going in, thanks @absrocks! |
No description provided.