-
Notifications
You must be signed in to change notification settings - Fork 773
ensure that configure step of Zoltan uses an up-to-date config.guess
#23068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure that configure step of Zoltan uses an up-to-date config.guess
#23068
Conversation
|
@boegelbot please test @ jsc-zen3 |
|
@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2958944697 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @bedroge |
|
Test report by @boegel |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Going in, thanks @bedroge! |
A Zoltan build for EESSI on a Neoverse v1 node resulted in:
(see EESSI/software-layer#1113 (comment))
Zoltan includes a very old
config.guess(https://github.com/sandialabs/Zoltan/blob/v3.901/config/config.guess). Although EasyBuild should obtain a new version of this file, that's not being done here due to building in a subdirectory and usingconfigure_cmd = ../configure:The
../configureleads toos.path.exists(configure_command)being False for this check, as that's being run in the root of the source dir: https://github.com/easybuilders/easybuild-easyblocks/blob/develop/easybuild/easyblocks/generic/configuremake.py#L314.By using an absolute path to the configure script, the script is found and
self.determine_build_and_host_type()will be called, which solves the issue.