Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented May 31, 2025

(created using eb --new-pr)

partial fix for #22763

@boegel
Copy link
Member Author

boegel commented May 31, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="Rust-1.70.0-GCCcore-12.3.0.eb maturin-1.1.0-GCCcore-12.3.0.eb jupyter-server-2.7.2-GCCcore-12.3.0.eb nbclassic-1.0.0-GCCcore-12.3.0.eb polars-0.19.19-gfbf-2023a.eb pymatgen-2023.12.18-foss-2023a.eb torch-em-0.7.1-foss-2023a.eb"
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS="Rust-1.70.0-GCCcore-12.3.0.eb maturin-1.1.0-GCCcore-12.3.0.eb jupyter-server-2.7.2-GCCcore-12.3.0.eb nbclassic-1.0.0-GCCcore-12.3.0.eb polars-0.19.19-gfbf-2023a.eb pymatgen-2023.12.18-foss-2023a.eb torch-em-0.7.1-foss-2023a.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6534

Test results coming soon (I hope)...

- notification for comment with ID 2924804453 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
jsczen3c4.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/00afeff63652b038ee9266894a461560 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 31, 2025

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6537

Test results coming soon (I hope)...

- notification for comment with ID 2925164957 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented May 31, 2025

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3902.accelgor.os - Linux RHEL 9.4, x86_64, AMD EPYC 7413 24-Core Processor (zen3), 1 x NVIDIA NVIDIA A100-SXM4-80GB, 570.133.20, Python 3.9.18
See https://gist.github.com/boegel/50db15646b3ef9bc5ec2dc6e6003c003 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 6 (6 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/7f3694c55b8a65f65b92f7408ffbbcd1 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 31, 2025

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6543

Test results coming soon (I hope)...

- notification for comment with ID 2925237278 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 5 out of 6 (6 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/c00fdb95c0653dfcabb1b2b57e2b4a4f for a full test report.

@boegel
Copy link
Member Author

boegel commented May 31, 2025

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16

@easybuilders easybuilders deleted a comment from boegelbot May 31, 2025
@easybuilders easybuilders deleted a comment from boegelbot May 31, 2025
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6551

Test results coming soon (I hope)...

- notification for comment with ID 2925693147 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 5 out of 6 (6 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/5d27737b4ea1cb8bb8b4498d36e241d4 for a full test report.

@boegel
Copy link
Member Author

boegel commented May 31, 2025

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3534.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/3678d1897c1df1122973586f26fc5a60 for a full test report.

…t required at all) + use PythonPackage easyblock
@boegel
Copy link
Member Author

boegel commented Jun 2, 2025

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6577

Test results coming soon (I hope)...

- notification for comment with ID 2929869510 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 5 out of 6 (6 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/337ea60988210e20d2b16e513795084c for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 2, 2025

Taking a look why pymatgen-2023.12.18-foss-2023a.eb failed, I'm not seeing that on our systems... 🤔

edit: error is pretty clear, when installing orjson extension:

ModuleNotFoundError: No module named 'maturin'

So maturin is required for installing pymatgen.

Same problem locally (I was using pymatgen-2024.5.1-foss-2023b.eb instead of pymatgen-2023.12.18-foss-2023a.eb before...), so will fix by adding back maturin for pymatgen.
Problem doesn't occur with pymatgen-2024.5.1-foss-2023b.eb because orjson is a separate installation there (via orjson-3.10.10-GCCcore-13.2.0.eb).

edit: pymatgen only requires maturin, not Rust, so no need to use CargoPythonPackage

@boegel
Copy link
Member Author

boegel commented Jun 3, 2025

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6588

Test results coming soon (I hope)...

- notification for comment with ID 2934090712 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 5 out of 6 (6 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/c0daabfae39863e21a90a380329c1295 for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 6, 2025

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6624

Test results coming soon (I hope)...

- notification for comment with ID 2949903786 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/8866c22b695235133ba38bfbffa407ef for a full test report.

@@ -1,4 +1,4 @@
easyblock = 'PythonBundle'
easyblock = 'CargoPythonBundle'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orjson is a rust package

crates = [
    ('ahash', '0.8.6'),
    ('arrayvec', '0.7.4'),
    ('associative-cache', '2.0.0'),
    ('autocfg', '1.1.0'),
    ('beef', '0.5.2'),
    ('bytecount', '0.6.7'),
    ('castaway', '0.2.2'),
    ('cc', '1.0.83'),
    ('cfg-if', '1.0.0'),
    ('chrono', '0.4.31'),
    ('compact_str', '0.7.1'),
    ('encoding_rs', '0.8.33'),
    ('itoa', '1.0.9'),
    ('itoap', '1.0.1'),
    ('libc', '0.2.149'),
    ('libm', '0.2.8'),
    ('no-panic', '0.1.26'),
    ('num-traits', '0.2.17'),
    ('once_cell', '1.18.0'),
    ('packed_simd', '0.3.9'),
    ('proc-macro2', '1.0.69'),
    ('pyo3-build-config', '0.20.0'),
    ('pyo3-ffi', '0.20.0'),
    ('quote', '1.0.33'),
    ('rustversion', '1.0.14'),
    ('ryu', '1.0.15'),
    ('serde', '1.0.190'),
    ('serde_derive', '1.0.190'),
    ('serde_json', '1.0.107'),
    ('simdutf8', '0.1.4'),
    ('smallvec', '1.11.1'),
    ('static_assertions', '1.1.0'),
    ('syn', '2.0.38'),
    ('target-lexicon', '0.12.12'),
    ('unicode-ident', '1.0.12'),
    ('version_check', '0.9.4'),
    ('zerocopy', '0.7.15'),
    ('zerocopy-derive', '0.7.15'),
]

I.. really don't understand how this could pass a build without this. We should be setting cargo to offline mode, but maybe the maturin/pip wrapper thing overrides those environment variables, allowing it to go online?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was also a bit puzzled about how this could work without providing a list of crates...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this explains it?

== 2025-05-31 23:13:07,252 easyblock.py:3091 DEBUG Installing extension orjson with default class PythonPackage (from easybuild.easyblocks.generic.pythonpackage)

In pymatgen-2024.5.1-foss-2023b.eb, orjson has been lifted in a proper dependency, so situation is different there.

Copy link
Member Author

@boegel boegel Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket CargoPythonBundle should make sure that CargoPythonPackage is used for all extensions, so Cargo.extract_step (which ends up setting $CARGO_NET_OFFLINE to true is used for every extension?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, no, should be fine, the log tells me that $CARGO_NET_OFFLINE is being set to true right before the installation of every extension, including orjson

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's being set, but then later being unset again, before the actual pip install happens:

egrep 'installing.*extension|CARGO_NET_OFFLINE|Running shell command.*pip install.*orjson' /software/pymatgen/2023.12.18-foss-2023a/easybuild/*log*
...
== 2025-05-31 23:15:56,812 environment.py:93 INFO Environment variable CARGO_NET_OFFLINE set to true (previously undefined)
== 2025-05-31 23:15:56,852 build_log.py:322 INFO installing extension orjson 3.9.10 (13/25)...
== 2025-05-31 23:15:57,920 environment.py:172 DEBUG Key in old environment found that is not in new one: CARGO_NET_OFFLINE (true)
== 2025-05-31 23:16:05,368 run.py:500 INFO Running shell command '/user/gent/400/vsc40023/eb_arcaninescratch/RHEL9/zen2-ib/software/Python/3.11.3-GCCcore-12.3.0/bin/python -m pip install --prefix=/user/gent/400/vsc40023/eb_arcaninescratch/RHEL9/zen2-ib/software/pymatgen/2023.12.18-foss-2023a  --verbose --no-deps --ignore-installed --no-build-isolation .' in /tmp/vsc40023/easybuild_build/pymatgen/2023.12.18/foss-2023a/orjson/orjson-3.9.10

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is that $CARGO_NET_OFFLINE is not being set by Cargo.set_cargo_vars, which results in it not being set anymore when the actual installation of extensions is done.

That's probably an unexpected side effect from the changes implemented in easybuilders/easybuild-framework#4868

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the specific version of orjson being used here (3.9.10), it seems like cargo doesn't need to download anything at all, because the sources of the requires crates are included in the source tarball or orjson:

eb-shell> pwd
/tmp/vsc40023/easybuild_build/pymatgen/2023.12.18/foss-2023a/orjson/orjson-3.9.10
eb-shell> ls include/cargo/
ahash-0.8.6              bytecount-0.6.7  compact_str-0.7.1   libm-0.2.8         proc-macro2-1.0.69        ryu-1.0.15            smallvec-1.11.1          version_check-0.9.4
arrayvec-0.7.4           castaway-0.2.2   encoding_rs-0.8.33  no-panic-0.1.26    pyo3-build-config-0.20.0  serde-1.0.190         static_assertions-1.1.0  zerocopy-0.7.15
associative-cache-2.0.0  cc-1.0.83        itoa-1.0.9          num-traits-0.2.17  pyo3-ffi-0.20.0           serde_derive-1.0.190  syn-2.0.38               zerocopy-derive-0.7.15
autocfg-1.1.0            cfg-if-1.0.0     itoap-1.0.1         once_cell-1.18.0   quote-1.0.33              serde_json-1.0.107    target-lexicon-0.12.12
beef-0.5.2               chrono-0.4.31    libc-0.2.149        packed_simd-0.3.9  rustversion-1.0.14        simdutf8-0.1.4        unicode-ident-1.0.12

So although easybuilders/easybuild-easyblocks#3764 is a correct fix, we don't actually need to provide a list of crates at all for this pymatgen easyconfig, since all crates required by the orjson extension included in it are shipped/vendored with it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make a comment that explains that this specific older version of orjson used vendored crates.
Updating to newer versions will require adding the crates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Micket OK, makes sense, done in f21d6b6

@boegel
Copy link
Member Author

boegel commented Jun 7, 2025

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3764 pymatgen-2023.12.18-foss-2023a.eb --installpath /tmp/$USER/pr22983"

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS="--include-easyblocks-from-pr 3764 pymatgen-2023.12.18-foss-2023a.eb --installpath /tmp/$USER/pr22983" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6633

Test results coming soon (I hope)...

- notification for comment with ID 2952147992 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3764
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/fe0dfb964b8a722c75ffffa70f250ab4 for a full test report.

@boegel
Copy link
Member Author

boegel commented Jun 7, 2025

@boegelbot please test @ jsc-zen3-a100
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22983 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22983 --ntasks="16" --partition=jsczen3g --gres=gpu:1 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6635

Test results coming soon (I hope)...

- notification for comment with ID 2952492705 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen3g1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), 1 x NVIDIA NVIDIA A100 80GB PCIe, 555.42.06, Python 3.9.21
See https://gist.github.com/boegelbot/f13b7fcabb491b2c3c1d492b38b5819a for a full test report.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit c43994b into easybuilders:develop Jun 11, 2025
8 checks passed
@boegel boegel deleted the 20250531113359_new_pr_maturin110 branch June 11, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants