-
Notifications
You must be signed in to change notification settings - Fork 773
{vis}[GCCcore/12.3.0,GCCcore/13.3.0] GraphicsMagick v1.3.45 for GCCcore-12.3.0 + use patch to fix pkgconfig file for GraphicsMagick 1.3.45 #22930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated software
|
|
Test report by @Crivella |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2900581753 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
GraphicMagick-1.3.45 EC for GCCcore-12.3.0 with potential fix for OctaveGraphicMagick-1.3.45 EC for GCCcore-12.3.0 + fix for #22927
|
Test report by @Crivella NotesThis can serve as an example of the |
|
Test report by @Crivella |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2900823237 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @Crivella |
GraphicMagick-1.3.45 EC for GCCcore-12.3.0 + fix for #22927GraphicsMagick-1.3.45 EC for GCCcore-12.3.0 + fix for #22927
| sanity_check_commands = [ | ||
| "pkg-config --cflags GraphicsMagick", | ||
| "pkg-config --cflags GraphicsMagick++", | ||
| "pkg-config --cflags GraphicsMagickWand", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're relying on the OS having pkg-config installed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I've added the pkgconf to the normal dependencies (70e1fd8), by looking at the code I do not see an easy way to have an equivalent of builddependencies for sanity checks.
As far as i understand, the dependencies for the sanity check are pulled in through the creation of a fake module, which filters out the deps marked as build_only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, build dependencies won't be loaded anymore during sanity check (and that's intentional).
I guess we could consider introducing a concept like sanity_check_deps, i.e. extra module that should be loaded only during the sanity check (not by the module that's generated).
You could look into easybuilders/easybuild-framework#4766 for inspiration for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would just suffice to check that the .pc files exist rather than complicating things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that the patch file is adding a required dependency to LibTIFF which before was done by looking for libtiff.pc but as far back as i could check it should be libtiff-4.pc (not sure if the foss 2020b versiona ctually required libtiff.pc).
This was causing the pkgconfig command to fail eg during the installation of Octave.
I am not sure we should be checking the pkgconfig of a separate package than the installation manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe just do a grep on libtiff-4 in the pc file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess i also wanted to future-proof this against changes in the LibTIFF dependency, but that could make sense since it would require also changing the patch files 🤔
|
Test report by @boegelbot |
|
Running another local test after 70e1fd8 This was also tested in as a dependency for Octave |
|
Test report by @Crivella |
b6bb277 to
f9f9039
Compare
|
Switched to using This package is only used in |
|
@boegelbot please test @ jsc-zen3 |
|
Test report by @Crivella |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2958438990 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
easybuild/easyconfigs/g/GraphicsMagick/GraphicsMagick-1.3.45-GCCcore-13.3.0.eb
Outdated
Show resolved
Hide resolved
easybuild/easyconfigs/g/GraphicsMagick/GraphicsMagick_pkgconfig_libtiff-4.patch
Show resolved
Hide resolved
|
Test report by @Crivella |
ocaisa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@boegelbot please test @ jsc-zen3 |
|
@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3057347414 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @ocaisa |
|
Test report by @boegelbot |
|
I can only test a single version locally as I miss the rest of the stack, but in general things look good, thanks @Crivella |
GraphicsMagick-1.3.45 EC for GCCcore-12.3.0 + fix for #22927GraphicsMagick-1.3.45 EC for GCCcore-12.3.0 + fix pkgconfig file for GraphicsMagick 1.3.45
GraphicsMagick-1.3.45 EC for GCCcore-12.3.0 + fix pkgconfig file for GraphicsMagick 1.3.45
New EC files for
GraphicsMagickandfoss/2023awith potential fix forpkg-configfails due to misnamedlibtiff-4.pcfile #22927GraphicsMagicklibrary #22929If from the discussion on the PR/Issue it is decided this is the proper way to go we should apply the change to enable both static and shared builds (+ sanity checks)
also to
GraphicsMagick-1.3.45-GCCcore-13.3.0.eb