Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented May 20, 2025

(created using eb --new-pr)

edit: $CONDA_PREFIX is not a path-like variable, so setting it via modextrapaths is incorrect.
Moreover, the changes in easybuilders/easybuild-framework#4868 broke the QIIME2 easyconfigs, because the unifrac extension requires that $CONDA_PREFIX is set to something, and the new module_load_environment approach doesn't set $CONDA_PREFIX if the installation directory is just an empty directory when it's set via modextrapaths (see also discussion in #22905)

@lexming
Copy link
Contributor Author

lexming commented May 20, 2025

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22918 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22918 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 6400

Test results coming soon (I hope)...

- notification for comment with ID 2894531370 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel changed the title define CONDA_PREFIX as modextravar in QIIME2 define $CONDA_PREFIX via modextravars in QIIME2 May 20, 2025
@boegel boegel removed the change label May 20, 2025
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/8fdbd35b479b71c4f86cf7d2945a0944 for a full test report.

@boegel boegel merged commit f18fc60 into easybuilders:develop May 20, 2025
8 checks passed
@lexming lexming deleted the 20250520155949_new_pr_QIIME2202351 branch May 21, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants