Skip to content

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented Apr 24, 2025

@lexming lexming force-pushed the 20250424141300_new_pr_JupyterLab350 branch from 31cf5df to efa2da3 Compare April 24, 2025 15:20
@boegel boegel added this to the next release (5.1.0) milestone May 21, 2025
@boegel boegel changed the title replace setenv commands with environment variables in module footers with modextravars replace setenv commands with environment variables in module footers with modextravars in easyconfigs for HIP, JupyterLab, mujoco-py, Triton May 21, 2025
@boegel
Copy link
Member

boegel commented May 22, 2025

Works like a charm:

$ grep -R JUPYTERLAB_SETTINGS_DIR $EASYBUILD_INSTALLPATH/modules/all/JupyterLab/4.2.0-GCCcore-13.2.0.lua
/modules/all/JupyterLab/4.2.0-GCCcore-13.2.0.lua:setenv("JUPYTERLAB_SETTINGS_DIR", pathJoin(os.getenv("HOME"), ".jupyter", "lab", "user-settings"))

$ module load JupyterLab/4.2.5-GCCcore-13.3.0
$ echo $JUPYTERLAB_SETTINGS_DIR
/users/example/.jupyter/lab/user-settings

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented May 22, 2025

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3625.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/24fd043d84310967870bdce23d5245c9 for a full test report.

@boegel
Copy link
Member

boegel commented May 22, 2025

Going in, thanks @lexming!

@boegel boegel merged commit 5819795 into easybuilders:develop May 22, 2025
8 checks passed
@lexming lexming deleted the 20250424141300_new_pr_JupyterLab350 branch May 22, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants