-
Notifications
You must be signed in to change notification settings - Fork 764
Basix/0.9.0-gfbf-2024a, nanobind/2.6.1-GCCcore-13.3.0.eb, robin-map/1.4.0-GCCcore-13.3.0, scikit-build-core/0.11.0-GCCcore-13.3.0 #22697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Updated software
|
|
It appears the |
|
@sassy-crick : I would like to revive this PR and bring it back to life. Are there still any steps I shall take to have it tested? Unfortunately, the easyblock cannot be automatically found, and few tests fail. How can I resolve this issue? |
|
Are there any particular reasons why we include the newer versions of |
| parallel = 8 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason why we set this to 8?
Typically, this would be handled by users by their parallel and max-parallel config options.
There might be a reason to set it to 1, e.g. when a parallel build causes build failures. But I don't think this is the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I removed it in 72d63e5.
| 'download_dep_fail': True, | ||
| 'use_pip': True, | ||
| 'sanity_pip_check': True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think those should be set by EB 5.x by default, so we don't need to specify them here anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaned up in 72d63e5.
|
Based on the discussion in easybuilders/easybuild-easyblocks#3684, trying |
This PR was pushed on 3 April whereas the older versions of |
The commit 6befba9 retracts the proposed easyconfigs for those conflicting modules to adopt the existing versions from the 2024a toolchain. |
This PR adds
Basixwhich is one of the dependencies ofDOLFINx.requires:
Furthermore, these new easyconfigs are either created or a newer version is proposed:
scikit-build-core/0.11.0-GCCcore-13.3.0robin-map/1.4.0-GCCcore-13.3.0nanobind/2.6.1-GCCcore-13.3.0I also have to admit that this PR is inspired by PR #22422.