Skip to content

Conversation

@casparvl
Copy link
Contributor

@casparvl casparvl commented Jan 22, 2025

(created using eb --new-pr)

Change requested here: #21765 (comment)

@casparvl casparvl changed the title move download of data files to source step to facilitate e.g. offline installation {astro}[foss/2022a][foss/2023b] move download of data files to source step to facilitate e.g. offline installation Jan 22, 2025
@casparvl casparvl changed the title {astro}[foss/2022a][foss/2023b] move download of data files to source step to facilitate e.g. offline installation {astro}[foss/2022a,foss/2023b] Casacore 3.5.0 - move download of data files to source step Jan 22, 2025
@casparvl casparvl changed the title {astro}[foss/2022a,foss/2023b] Casacore 3.5.0 - move download of data files to source step {astro}[foss/2022a,foss/2023b] Casacore v3.5.0 - move download of data files to source step Jan 22, 2025
@casparvl
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22201 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22201 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5573

Test results coming soon (I hope)...

Details

- notification for comment with ID 2608237896 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/bd3543949c2cbe30a8fc59190204e76b for a full test report.

@casparvl
Copy link
Contributor Author

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 9.4, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.9.18
See https://gist.github.com/casparvl/2868d227e8e9c8b462c265fd82708b7f for a full test report.

boegel
boegel previously requested changes Jan 24, 2025
…lcmds. Also, add sanity checking on presense of the datadir contents
@casparvl
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22201 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22201 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5623

Test results coming soon (I hope)...

Details

- notification for comment with ID 2620054287 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/bc7a87c50332eef8da529e68c99f4edb for a full test report.

@casparvl
Copy link
Contributor Author

Hmpf, seems the measures tarball isn't static, it is the latest release of the measures. The ftp also seems to contain tarballs for fixed dates, so I'll fix the date, so I can fix the checksum. I'll also include instructions on how to update in the module descritpion, if end-users want to use newer data.

@casparvl
Copy link
Contributor Author

Test report by @casparvl
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 9.4, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.9.18
See https://gist.github.com/casparvl/bd43e01a1112920709bedbcab9694a8f for a full test report.

@casparvl
Copy link
Contributor Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=22201 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_22201 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5625

Test results coming soon (I hope)...

Details

- notification for comment with ID 2620197693 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/8a4d6f51dde9788dbbce5f74ddfb3ad2 for a full test report.

@casparvl
Copy link
Contributor Author

Test report by @casparvl
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 9.4, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.9.18
See https://gist.github.com/casparvl/31e21cfa2f6824027127adebff668917 for a full test report.

@boegel boegel added bug fix and removed change labels Jan 29, 2025
@casparvl casparvl requested a review from boegel January 29, 2025 20:28
@github-actions github-actions bot added the change label Feb 7, 2025
Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bedroge bedroge dismissed boegel’s stale review February 7, 2025 18:51

Requested change has been implemented

@bedroge
Copy link
Contributor

bedroge commented Feb 7, 2025

Test report by @bedroge
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 24.04.1 LTS (Noble Numbat), x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.12.3
See https://gist.github.com/bedroge/398bbfd278efe2d1df9acd916ba9f9c9 for a full test report.

edit: forgot to include the easyblock from easybuilders/easybuild-easyblocks#3463, and now it picked up my OS Python, trying again...

@bedroge
Copy link
Contributor

bedroge commented Feb 7, 2025

Test report by @bedroge
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in total)
interactive2 - Linux Rocky Linux 8.10, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.6.8
See https://gist.github.com/bedroge/80b69a8f0746cae0025745f8c868ae9f for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Feb 7, 2025

Test report by @bedroge
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3463
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 24.04.1 LTS (Noble Numbat), x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.12.3
See https://gist.github.com/bedroge/25d0b01538507f3d1fcc29a857fda274 for a full test report.

Copy link
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@bedroge bedroge added this to the release after 4.9.4 milestone Feb 7, 2025
@bedroge
Copy link
Contributor

bedroge commented Feb 7, 2025

Going in, thanks @casparvl!

@bedroge bedroge merged commit f4834e6 into easybuilders:develop Feb 7, 2025
10 checks passed
@boegel boegel changed the title {astro}[foss/2022a,foss/2023b] Casacore v3.5.0 - move download of data files to source step move download of data files to source step for Casacore v3.5.0 Feb 12, 2025
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants