-
Notifications
You must be signed in to change notification settings - Fork 773
move download of data files to source step for Casacore v3.5.0 #22201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move download of data files to source step for Casacore v3.5.0 #22201
Conversation
|
@boegelbot please test @ jsc-zen3 |
|
@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2608237896 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @casparvl |
…lcmds. Also, add sanity checking on presense of the datadir contents
|
@boegelbot please test @ jsc-zen3 |
|
@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2620054287 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Hmpf, seems the measures tarball isn't static, it is the latest release of the measures. The ftp also seems to contain tarballs for fixed dates, so I'll fix the date, so I can fix the checksum. I'll also include instructions on how to update in the module descritpion, if end-users want to use newer data. |
|
Test report by @casparvl |
|
@boegelbot please test @ jsc-zen3 |
|
@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 2620197693 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @casparvl |
Co-authored-by: Bob Dröge <[email protected]>
bedroge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Requested change has been implemented
|
Test report by @bedroge edit: forgot to include the easyblock from easybuilders/easybuild-easyblocks#3463, and now it picked up my OS Python, trying again... |
|
Test report by @bedroge |
|
Test report by @bedroge |
bedroge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
|
Going in, thanks @casparvl! |
(created using
eb --new-pr)Change requested here: #21765 (comment)