Skip to content

{phys}[foss/2023a] CORSIKA v77550 #20693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smoors merged 5 commits into from
Sep 6, 2024
Merged

{phys}[foss/2023a] CORSIKA v77550 #20693

smoors merged 5 commits into from
Sep 6, 2024

Conversation

@lexming
Copy link
Contributor

@lexming lexming commented May 31, 2024

(created using eb --new-pr)

@lexming lexming added the new label May 31, 2024
@lexming
Copy link
Contributor Author

lexming commented Jun 5, 2024

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node601.hydra.os - Linux Rocky Linux 8.9, x86_64, AMD EPYC 9384X 32-Core Processor (x86_64_v4), Python 3.6.8
See https://gist.github.com/lexming/52b4f55dbac03d0c70155900652432f8 for a full test report.

@lexming lexming mentioned this pull request Jun 7, 2024
Open
@smoors
Copy link
Contributor

smoors commented Aug 21, 2024

Test report by @smoors
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux Rocky Linux 8.10, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/smoors/030ea58b1724156e67f32ee6658f3446 for a full test report.

lexming
lexming commented Sep 6, 2024
View reviewed changes
Copy link
Contributor Author

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smoors smoors added this to the release after 4.9.2 milestone Sep 6, 2024
smoors
smoors approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too!

@smoors
Copy link
Contributor

smoors commented Sep 6, 2024

Going in, thanks @lexming!

@smoors smoors merged commit 6bcb684 into easybuilders:develop Sep 6, 2024
@lexming lexming deleted the 20240531100929_new_pr_CORSIKA77550 branch September 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.9.3

Development

Successfully merging this pull request may close these issues.

3 participants

@lexming @smoors @verdurin