Skip to content

fix wrong version of, and missing, extensions in recent Perl easyconfigs #18789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Oct 28, 2023
Merged

fix wrong version of, and missing, extensions in recent Perl easyconfigs #18789

boegel merged 1 commit into from
Oct 28, 2023

Conversation

@akesandgren
Copy link
Contributor

@akesandgren akesandgren commented Sep 14, 2023 •
edited
Loading

(created using eb --new-pr)

Depends on (or rather fixes problems detected by) easybuilders/easybuild-easyblocks#2699

@akesandgren
Copy link
Contributor Author

akesandgren commented Sep 14, 2023

@boegel Can you kick of a test of these with the 2699 easyblock PR.
I think I got them all right now...

@branfosj
Copy link
Member

branfosj commented Sep 16, 2023

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 2699"

@branfosj branfosj added this to the next release (4.8.2?) milestone Sep 16, 2023
@boegelbot
Copy link
Collaborator

boegelbot commented Sep 16, 2023

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=18789 EB_ARGS="--include-easyblocks-from-pr 2699" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_18789 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11724

Test results coming soon (I hope)...

Details

- notification for comment with ID 1722221761 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member

branfosj commented Sep 16, 2023

Test report by @branfosj
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2699
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
bear-pg0211u03a.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/branfosj/13960708c8bfb28aec07a24bd8d4f4b2 for a full test report.

@boegelbot
Copy link
Collaborator

boegelbot commented Sep 16, 2023

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2699
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/aae9bb67d1bd1026be997936d5635b06 for a full test report.

boegel
boegel reviewed Oct 11, 2023
View reviewed changes
easybuild/easyconfigs/p/Perl/Perl-5.30.2-GCCcore-9.3.0.eb
'source_urls': ['https://cpan.metacpan.org/authors/id/M/ML/MLEHMANN/'],
'checksums': ['a86a1c4ca4f3006d7479064425a09fa5b6689e57261fcb994fe67d061cba0e7e'],
}),
('IO::Compress::Bzip2', '2.096', {
Copy link
Member

@boegel boegel Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren Can you clarify why this has to be removed?

Copy link
Member

@boegel boegel Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akesandgren ping?

Copy link
Contributor Author

@akesandgren akesandgren Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's part of Perl main code if I remember correctly now....

Copy link
Contributor Author

@akesandgren akesandgren Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if left something failed in the tests due to this, probably something about incompatible bzip/zip/... levels

@boegel
Copy link
Member

boegel commented Oct 11, 2023

@boegelbot please test @ jsc-zen2
EB_ARGS="--include-easyblocks-from-pr 2699"

@boegelbot
Copy link
Collaborator

boegelbot commented Oct 11, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=18789 EB_ARGS="--include-easyblocks-from-pr 2699" EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_18789 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3531

Test results coming soon (I hope)...

Details

- notification for comment with ID 1758305383 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

boegelbot commented Oct 11, 2023

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2699
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/e1b176c6d5b00335689f1717308dfc43 for a full test report.

@boegel boegel mentioned this pull request Oct 27, 2023
Open
@boegel
Copy link
Member

boegel commented Oct 27, 2023 •
edited
Loading

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/1effd3d5e3ae03f410c709270cf0a847 for a full test report.

edit: reinstall of these easyconfigs, without using updated easyblock from easybuilders/easybuild-easyblocks#2699 (merging that requires more effort, but this PR can already be merged since it doesn't rely on the changes in easybuilders/easybuild-easyblocks#2699)

@boegel
Copy link
Member

boegel commented Oct 27, 2023

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#2699
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/489157077df4503763f421a7cb55c684 for a full test report.

@boegel
Copy link
Member

boegel commented Oct 28, 2023

Going in, thanks @akesandgren!

@boegel boegel merged commit c90179c into easybuilders:develop Oct 28, 2023
@akesandgren akesandgren deleted the 20230914215521_new_pr_Perl5281 branch October 30, 2023 06:27
@boegel boegel changed the title fix wrong version of, and missing, extensions for Perl, detected by easyblock PR 2699 fix wrong version of, and missing, extensions in recent Perl easyconfigs Nov 8, 2023
@branfosj branfosj mentioned this pull request Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.8.2

Development

Successfully merging this pull request may close these issues.

4 participants

@akesandgren @branfosj @boegelbot @boegel