Add egg file to OpenCV 4.6.0 python package for pip + pkgconfig file #17779

Micket · 2023-04-21T13:27:11Z

Add egg-info file to make packages show up in pip

Procedure was stolen from what we have done in VTK

Micket · 2023-04-24T18:20:50Z

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/cef2524c0d7d91fb58c772fb62d63f52 for a full test report.

Micket · 2023-04-24T18:42:17Z

Erh, what am I missing here

This approach is working fine with VTK

$ cat /apps/Test2/software/VTK/9.2.2-foss-2022a/lib/python3.10/site-packages/vtk-9.2.2.egg-info 
Metadata-Version: 2.1
Name: vtk
Version: 9.2.2
Summary: VTK is an open-source toolkit for 3D computer graphics, image processing, and visualization
Platform: UNKNOWN

# pip list  | grep vtk
vtk                               9.2.2

# pip show vtk
Name: vtk
Version: 9.2.2
Summary: VTK is an open-source toolkit for 3D computer graphics, image processing, and visualization
Home-page: 
Author: 
Author-email: 
License: 
Location: /apps/Test2/software/VTK/9.2.2-foss-2022a/lib/python3.10/site-packages
Requires: 
Required-by:

and with this PR on OpenCV

 cat /apps/Test2/software/OpenCV/4.6.0-foss-2022a-contrib/lib/python3.10/site-packages/opencv-contrib-python-4.6.0.egg-info 
Metadata-Version: 2.1
Name: opencv-contrib-python
Version: 4.6.0
Summary: Wrapper package for OpenCV python bindings.
Platform: UNKNOWN

# pip list | grep opencv
opencv-contrib-python             4.6.0

So far so good!

$ pip show opencv-contrib-python
WARNING: Package(s) not found: opencv-contrib-python

$ pip show opencv
Name: opencv-contrib-python
Version: 4.6.0
Summary: Wrapper package for OpenCV python bindings.
Home-page: 
Author: 
Author-email: 
License: 
Location: /apps/Test2/software/OpenCV/4.6.0-foss-2022a-contrib/lib/python3.10/site-packages
Requires: 
Required-by:

wtf, it literally doesn't say just "opencv" anywhere.

akesandgren · 2023-05-09T15:07:21Z

I think the filename should be opencv_contrib_python-4.6.0
at least that's what every other pkg does that I can find.

Micket · 2023-05-09T19:03:27Z

Test report by @Micket
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/a6049a54c3e6f47053a86682045009ca for a full test report.

akesandgren · 2023-05-10T05:31:36Z

easybuild/easyconfigs/o/OpenCV/OpenCV-4.6.0-foss-2022a-CUDA-11.7.0-contrib.eb

+local_egg_info_src = '%(builddir)s/opencv-contrib-python.egg-info'
+local_egg_info_dest = '%(installdir)s/lib/python%(pyshortver)s/site-packages/opencv-contrib-python-%(version)s.egg-info'


Need to change filename here too

akesandgren · 2023-05-10T05:31:50Z

easybuild/easyconfigs/o/OpenCV/OpenCV-4.6.0-foss-2022a-contrib.eb

+local_egg_info_src = '%(builddir)s/opencv-contrib-python.egg-info'
+local_egg_info_dest = '%(installdir)s/lib/python%(pyshortver)s/site-packages/opencv-contrib-python-%(version)s.egg-info'


Micket · 2023-05-10T10:18:29Z

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.7, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/0f39249158c87866f7a527ba0ab6cec1 for a full test report.

Micket · 2023-05-10T11:26:36Z

I can find pc file and pip info now, so i think this is good to go

Micket · 2023-05-10T14:36:17Z

@boegelbot please test @ generoso

boegelbot · 2023-05-10T14:40:10Z

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=17779 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17779 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 10773

Test results coming soon (I hope)...

Details

- notification for comment with ID 1542319694 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-05-10T17:39:49Z

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/392e5978295090487534b5981b418f35 for a full test report.

akesandgren

LGTM

akesandgren · 2023-05-11T06:04:41Z

Going in, thanks @Micket!

Micket · 2023-05-11T11:09:55Z

@boegelbot please test @ jsc-zen2

boegelbot · 2023-05-11T11:12:08Z

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17779 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17779 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 2593

Test results coming soon (I hope)...

Details

- notification for comment with ID 1543798787 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-05-11T11:14:15Z

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/11990fa4c079f9b4d16f59187077a35e for a full test report.

Micket · 2023-05-11T11:58:23Z

@boegelbot please test @ jsc-zen2
EB_ARGS='--optarch=""'

boegelbot · 2023-05-11T12:02:08Z

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17779 EB_ARGS="--optarch=""" /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17779 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 2594

Test results coming soon (I hope)...

Details

- notification for comment with ID 1543865434 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-05-11T13:31:57Z

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/79638505fb9e50601cfcc53c80399a34 for a full test report.

Add egg file to OpenCV 4.6.0 python package for pip

fbd9fa6

Micket added the bug fix label Apr 21, 2023

This comment was marked as resolved.

Sign in to view

Fix checksums

e04695b

boegel added this to the next release (4.7.2) milestone Apr 21, 2023

Rename opencv egg info, also add pkg info file generation

3ee5447

Micket changed the title ~~Add egg file to OpenCV 4.6.0 python package for pip~~ Add egg file to OpenCV 4.6.0 python package for pip + pkgconfig file May 9, 2023

Fix patch filename

7aa8e3d

akesandgren requested changes May 10, 2023

View reviewed changes

Fix another incorrect filename path

0f4e754

Micket requested a review from akesandgren May 10, 2023 11:26

akesandgren approved these changes May 11, 2023

View reviewed changes

akesandgren merged commit be0f43f into easybuilders:develop May 11, 2023

Micket deleted the opencv_egg branch May 11, 2023 11:09

Micket restored the opencv_egg branch May 11, 2023 11:10

Micket deleted the opencv_egg branch May 11, 2023 15:00

Micket mentioned this pull request May 19, 2023

{ai}[foss/2022a] Ultralytics v8.0.92 w/ Python 3.10.4 #17894

Merged

branfosj mentioned this pull request Jun 6, 2023

{vis}[foss/2022a] Cellpose v2.2.2 w/ Python 3.10.4 #18004

Merged

		local_egg_info_src = '%(builddir)s/opencv-contrib-python.egg-info'
		local_egg_info_dest = '%(installdir)s/lib/python%(pyshortver)s/site-packages/opencv-contrib-python-%(version)s.egg-info'

Add egg file to OpenCV 4.6.0 python package for pip + pkgconfig file #17779

Add egg file to OpenCV 4.6.0 python package for pip + pkgconfig file #17779

Uh oh!

Conversation

Micket commented Apr 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Micket commented Apr 24, 2023

Uh oh!

Micket commented Apr 24, 2023

Uh oh!

akesandgren commented May 9, 2023

Uh oh!

Micket commented May 9, 2023

Uh oh!

akesandgren May 10, 2023

Choose a reason for hiding this comment

Uh oh!

akesandgren May 10, 2023

Choose a reason for hiding this comment

Uh oh!

Micket commented May 10, 2023

Uh oh!

Micket commented May 10, 2023

Uh oh!

Micket commented May 10, 2023

Uh oh!

boegelbot commented May 10, 2023

Uh oh!

boegelbot commented May 10, 2023

Uh oh!

akesandgren left a comment

Choose a reason for hiding this comment

Uh oh!

akesandgren commented May 11, 2023

Uh oh!

Micket commented May 11, 2023

Uh oh!

boegelbot commented May 11, 2023

Uh oh!

boegelbot commented May 11, 2023

Uh oh!

Micket commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

boegelbot commented May 11, 2023

Uh oh!

boegelbot commented May 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Micket commented Apr 21, 2023 •

edited

Loading

Micket commented May 11, 2023 •

edited

Loading