Skip to content

Conversation

@Micket
Copy link
Contributor

@Micket Micket commented Apr 20, 2023

(created using eb --new-pr)

This tripped me up https://gitlab.com/QEF/q-e/-/archive/qe-7.2/wtf_gitlab_why_does_this_work.tar.gz
works for some stupid reason, and gives you head. Install then downloads the source itself afterwards, so you might not even discover you got the wrong one downloaded and named incorrectly.

Didn't have time to look at the older stuff, this only really is a problem in rare situations, like gipaw not having a release yet

@Micket Micket added this to the next release (4.7.2) milestone Apr 20, 2023
@Micket Micket added the bug fix label Apr 20, 2023
@Micket
Copy link
Contributor Author

Micket commented Apr 20, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=17766 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17766 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10689

Test results coming soon (I hope)...

- notification for comment with ID 1516508660 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Contributor Author

Micket commented Apr 20, 2023

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-c1 - Linux Rocky Linux 8.6, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/Micket/d9a62c8ba3734000a8eca4a10e0b2e9f for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2c30b61416b89d1854cced857fbf9c21 for a full test report.

@Micket
Copy link
Contributor Author

Micket commented Apr 20, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=17766 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_17766 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 2546

Test results coming soon (I hope)...

- notification for comment with ID 1517015419 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/6fca9296ad282772bb98c2c7edbbf1ff for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Member

Going in, thanks @Micket!

@SebastianAchilles SebastianAchilles merged commit 1d05bea into easybuilders:develop Apr 23, 2023
@boegel boegel changed the title Only use QE gitlab source url for QE itself only use QEF gitlab source url for QuantumESPRESSO itself May 10, 2023
@Micket Micket deleted the 20230420165912_new_pr_QuantumESPRESSO71 branch May 26, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants