-
Notifications
You must be signed in to change notification settings - Fork 772
{bio}[system/system] SeaView v5.0.5 #17385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{bio}[system/system] SeaView v5.0.5 #17385
Conversation
|
Test report by @bedroge |
|
@boegelbot please test @ generoso |
|
Test report by @bedroge |
|
@bedroge: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1440684635 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Hmm, this executable actually has quite a lot of dependencies...: This will have to be reflected in the easyconfig somehow. |
|
@bedroge Should I add all dependencies explicitly even if they are provided by other dependencies? For example The full list would be: with these remaining: |
I think I'd prefer to make them explicit, also to prevent that things may break in the future if something changes in the dependencies of the dependencies. |
|
@bedroge I added all dependencies explicitly. |
| @@ -0,0 +1,45 @@ | |||
| easyblock = 'Tarball' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, rather than relying on binary installs, especially considering you have already added all the deps and moved this from SYSTEM to GCCcore, it just makes sense to build this from source, which would also add the benefit that this no longer just support x86
easybuild/easyconfigs/s/SeaView/SeaView-5.0.5-GCCcore-11.2.0.eb
Outdated
Show resolved
Hide resolved
|
@Micket I changed it to a installation from source, but there are quite some differences. These are the files included in the binary tarball: The only file build by the Makefile is The |
This comment was marked as resolved.
This comment was marked as resolved.
Some of those might have jut been picked up accidentally in whatever OS they linked to, or some might require enabling some optional feature at config time, but if you are happy with the final application as this, then so am I, i don't really know what it does (just reviewing this as a general GUI software build in EB) |
|
Test report by @Micket |
Micket
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if github is being slow today. I tried to approve this but it didn't appear. Risk of repeating myself; i made a small tweak moving the binary to the bin/ subdir. LGTM
|
@boegelbot please test @ generoso |
|
@Micket: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 1455133915 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
(created using
eb --new-pr)There is a test dataset included but as this is a GUI software I only added a check with
-h.