Skip to content

Combine errors of extension patch check into a single failure #17286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Mar 2, 2023
Merged

Combine errors of extension patch check into a single failure #17286

boegel merged 1 commit into from
Mar 2, 2023

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 9, 2023

Avoids repeated test runs by showing all errors at once.

Example from new output:

AssertionError: Verification of patches for TensorFlow-2.11.0-foss-2022a.eb failed:
Patch file TensorFlow-2.8.4_exclude-xnnpack-on-ppc.patch for extension TensorFlow is missing.
Patch file TensorFlow-2.8.4_resolve-gcc-symlinks.patch for extension TensorFlow is missing.
Patch file TensorFlow-2.9.1_remove-duplicate-gpu-tests.patch for extension TensorFlow is missing.

@Flamefire
Combine errors of extension patch check into a single failure
ce1cf57 
Avoids repeated test runs by showing all errors at once.
@Flamefire Flamefire marked this pull request as ready for review February 9, 2023 15:44
@Micket Micket added this to the next release (4.7.1?) milestone Feb 10, 2023
@boegel boegel added the tests label Feb 15, 2023
boegel
boegel approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 2, 2023

Going in, thanks @Flamefire!

@boegel boegel merged commit 9aae7e8 into easybuilders:develop Mar 2, 2023
@Flamefire Flamefire deleted the single-patch-error branch March 2, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

enhancement tests

Projects

None yet

Milestone

4.7.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @boegel @Micket