Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Feb 9, 2023

  • Create the script containing the (unexpanded) $EBROOT* variables.
  • Quote string to be echoed to make it easier to read and avoid the escaping

Extracted from #11149

$ cat software/shovill/1.1.0-gompi-2021b/bin/{pilon,trimmomatic}
exec java -jar "$EBROOTPILON"/pilon-*.jar "$@"
exec java -jar "$EBROOTTRIMMOMATIC"/trimmomatic-*.jar "$@"

@jfgrimm @boegel

- Create the script containing the (unexpanded) $EBROOT* variables.
- Quote string to be echoed to make it easier to read and avoid the escaping
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
taurusi6403.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/affc8dafd48f91aa5c86dc0ade1b73bb for a full test report.

@jfgrimm jfgrimm added this to the 4.x milestone Feb 9, 2023
@jfgrimm
Copy link
Member

jfgrimm commented Feb 9, 2023

Test report by @jfgrimm
FAILED
Build succeeded for 44 out of 51 (3 easyconfigs in total)
himem06.pri.viking.alces.network - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/b9ff7d7d00a18ffeeff71932002b5d53 for a full test report.

@Flamefire
Copy link
Contributor Author

@jfgrimm I noticed URLs for MEGAHIT and Velvet have changed (see Slack) and downloaded them manually. Might be worth fixing the ECs but as I don't have the old archives I couldn't compare them. Installation did work though.

@boegel boegel added the bug fix label Feb 9, 2023
@boegel boegel modified the milestones: 4.x, next release (4.7.1?) Feb 9, 2023
@boegel boegel changed the title Fix shovill postinstallcmds fix postinstallcmds in shovill easyconfigs Feb 10, 2023
@lexming
Copy link
Contributor

lexming commented Feb 11, 2023

@boegelbot: please test @ generoso
EB_ARGS="shovill-1.1.0-gompi-2021b.eb"

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=17279 EB_ARGS="shovill-1.1.0-gompi-2021b.eb" EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17279 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 10211

Test results coming soon (I hope)...

Details

- notification for comment with ID 1426701005 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/f935bdac86b6b6c36f8c32226a382fd0 for a full test report.

@lexming
Copy link
Contributor

lexming commented Feb 11, 2023

Test report by @lexming
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
node306.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.6.8
See https://gist.github.com/a087afea8d5d8622d800f733826285c6 for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Feb 11, 2023

Going in, thanks @Flamefire !

@lexming lexming merged commit b54598f into easybuilders:develop Feb 11, 2023
@Flamefire Flamefire deleted the fix-shovill-ecs branch February 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants