Skip to content

Conversation

@ThomasHoffmann77
Copy link
Contributor

@ThomasHoffmann77 ThomasHoffmann77 commented Dec 14, 2022

(created using eb --new-pr)
requires #16970

@SebastianAchilles SebastianAchilles added this to the 4.x milestone Dec 14, 2022
@SebastianAchilles
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@SebastianAchilles: Request for testing this PR well received on login1

PR test command 'EB_PR=16871 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16871 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9764

Test results coming soon (I hope)...

Details

- notification for comment with ID 1351722124 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/59ff5a741adc6e140b5e5f56fbaa3882 for a full test report.

@smoors
Copy link
Contributor

smoors commented Dec 16, 2022

@ThomasHoffmann77 the Pillow version that comes with the matplotlib builddep seems too old, it needs to be at least 9.1.0.
see also https://github.com/python-pillow/Pillow/pull/5954/files

    def __getattr__(name):
        if name == "PILLOW_VERSION":
            _raise_version_warning()
            return __version__
        else:
            categories = {"NORMAL": 0, "SEQUENCE": 1, "CONTAINER": 2}
            if name in categories:
                warnings.warn(
                    "Image categories are deprecated and will be removed in Pillow 10 "
                    "(2023-01-02). Use is_animated instead.",
                    DeprecationWarning,
                    stacklevel=2,
                )
                return categories[name]
>       raise AttributeError(f"module '{__name__}' has no attribute '{name}'")
E       AttributeError: module 'PIL.Image' has no attribute 'Resampling'

@ThomasHoffmann77
Copy link
Contributor Author

@smoors Would adding matplotlib and Pilllow to the jax exts_list be an appropriate solution? Not sure if we can use a lower version of jax for AlphaFold 2.3.0 #16874 (requirement: jax==0.3.25). Switching AlphaFold 2.3.0 to foss/2022a is blocked due to missing TensorFlow for this toolchain.

@smoors
Copy link
Contributor

smoors commented Dec 19, 2022

@ThomasHoffmann77 adding matplotlib and Pilllow to the jax exts_list can potentially create issues for users (for example) loading TensorFlow and matplotlib together. depending on the order of loading, you will get a different version.
also, doing this will change them from build dependencies to normal deps.

as matplotlib and Pillow are only build dependencies, an alternative would be to create easyconfigs for those. there is no single-dep-version rule for builddeps, only for normal deps.

the best solution IMHO would be to get TF 2.9.1 at 2022a over the finish line, see
#16620
#16008

@fizwit
Copy link
Contributor

fizwit commented Dec 21, 2022

@ThomasHoffmann77 @smoors back porting matplotlib-3.5.2 fixed the testing failures at my site and jax is building. Using Pillow-9.1.0 with matplotlib-3.5.2-foss-2021b at my site. I have many copies of Pillow because it is a depenedancy nightmare. If I was forced to use only one version Pillow per toolbox it would be impossible to deploy software to my customers.

@easybuilders easybuilders deleted a comment from boegelbot Dec 22, 2022
@smoors
Copy link
Contributor

smoors commented Dec 22, 2022

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=16871 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_16871 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 9878

Test results coming soon (I hope)...

Details

- notification for comment with ID 1362638878 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/7ea3586af2f3930ea26a21cdc943cbe7 for a full test report.

@smoors
Copy link
Contributor

smoors commented Dec 22, 2022

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=16871 EB_ARGS= /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_16871 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 1958

Test results coming soon (I hope)...

Details

- notification for comment with ID 1362880305 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/16be0a5b79cb85f0789dcf7e88cb30a4 for a full test report.

@smoors smoors modified the milestones: 4.x, next release (4.7.0) Dec 22, 2022
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented Dec 22, 2022

Going in, thanks @ThomasHoffmann77!

@smoors smoors merged commit 25b15a0 into easybuilders:develop Dec 22, 2022
@boegel boegel changed the title {tools}[foss/2021b] jax v0.3.23 w/ Python 3.9.6 {tools}[foss/2021b] jax v0.3.23 w/ Python 3.9.6 + CUDA 11.4.1 Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants