Skip to content

Conversation

@Micket
Copy link
Contributor

@Micket Micket commented Nov 2, 2021

(created using eb --new-pr)
Big problem remains: We had MATLAB's runtime libs conflict with our stuff, in particular, npm is broken here.

We should look into whether or not we need to add all those paths to LD_LIBRARY_PATH in MATLAB, I don't think they are actually necessary in most usecases.

@Micket Micket added the new label Nov 2, 2021
@boegelbot

This comment has been minimized.

@boegelbot

This comment has been minimized.

@boegelbot
Copy link
Collaborator

@Micket: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1416302957
Output from first failing test suite run:

(skipped conflicts test)
(skipped dep graph test)
Merge base for develop and HEAD: 17f3613c12e7b4d39fb8c44abeeb1dcff24362e2
Merge base for develop and HEAD: 17f3613c12e7b4d39fb8c44abeeb1dcff24362e2

List of added easyconfig files in this PR:
	jupyter-matlab-proxy-0.3.4-GCCcore-10.3.0-MATLAB-2021a.eb
======================================================================
FAIL: test__parse_easyconfig_jupyter-matlab-proxy-0.3.4-GCCcore-10.3.0-MATLAB-2021a.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig jupyter-matlab-proxy-0.3.4-GCCcore-10.3.0-MATLAB-2021a.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 1368, in innertest
    template_easyconfig_test(self, spec_path)
  File "test/easyconfigs/easyconfigs.py", line 1206, in template_easyconfig_test
    "binutils or GCC is a build dep in %s: %s" % (spec, dep_names))
AssertionError: binutils or GCC is a build dep in /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/j/jupyter-matlab-proxy/jupyter-matlab-proxy-0.3.4-GCCcore-10.3.0-MATLAB-2021a.eb: ['Python', 'JupyterLab', 'nodejs', 'Xvfb', 'MATLAB']

======================================================================
FAIL: test_dep_versions_per_toolchain_generation (test.easyconfigs.easyconfigs.EasyConfigTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 783, in test_dep_versions_per_toolchain_generation
    self.assertFalse(multi_dep_vars, error_msg)
AssertionError: No multi-variant deps found for '^.*-(?P<tc_gen>20(1[89]|[2-9][0-9])[ab]).*\.eb$' easyconfigs:

found 2 variants of 'nodejs' dependency in easyconfigs using '2021a' toolchain generation
* version: 14.17.0; versionsuffix:  as dep for set(['IRkernel-1.2-foss-2021a-R-4.1.0.eb', 'lavaan-0.6-9-foss-2021a-R-4.1.0.eb', 'rgeos-0.5-5-foss-2021a-R-4.1.0.eb', 'rjags-4-10-foss-2021a-R-4.1.0.eb', 'R-4.1.0-foss-2021a.eb', 'RStudio-Server-1.4.1717-foss-2021a-Java-11-R-4.1.0.eb', 'arrow-R-6.0.0.2-foss-2021a-R-4.1.0.eb', 'inferCNV-1.3.3-foss-2021a.eb', 'spatialreg-1.1-8-foss-2021a-R-4.1.0.eb', 'rgdal-1.5-23-foss-2021a-R-4.1.0.eb', 'ncdf4-1.17-foss-2021a-R-4.1.0.eb', 'Rgurobi-9.1.2-foss-2021a-R-4.1.0.eb', 'R-bundle-Bioconductor-3.13-foss-2021a-R-4.1.0.eb'])
* version: 14.17.2; versionsuffix:  as dep for set(['jupyter-matlab-proxy-0.3.4-GCCcore-10.3.0-MATLAB-2021a.eb'])


----------------------------------------------------------------------
Ran 13560 tests in 632.598s

FAILED (failures=2)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@Micket Micket marked this pull request as draft November 24, 2021 00:03
@Micket Micket marked this pull request as ready for review November 26, 2021 15:18
@Micket
Copy link
Contributor Author

Micket commented Nov 26, 2021

Updated based on zoom disucssion. Dropped matlab, replaced with a message. Also add patch for using EB installed matlab license by default.

@Micket
Copy link
Contributor Author

Micket commented Nov 26, 2021

@boegelbot please test @ generoso

@Micket Micket assigned akesandgren and unassigned akesandgren Nov 26, 2021
@Micket Micket requested a review from akesandgren November 26, 2021 16:13
@boegelbot
Copy link
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=14270 EB_ARGS= /opt/software/slurm/bin/sbatch --job-name test_PR_14270 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7366

Test results coming soon (I hope)...

- notification for comment with ID 980087222 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Contributor Author

Micket commented Nov 26, 2021

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/dbbc9215c933beb3ab0fd712785628b3 for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux rocky linux 8.4, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c1303e8ff93870e063116d5fe43f07f3 for a full test report.

@SebastianAchilles
Copy link
Member

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsfc01.int.jusuf.sebastian.cluster - Linux rocky linux 8.4, x86_64, AMD EPYC 7742 64-Core Processor (zen2), 1 x NVIDIA GRID V100-4C, 460.73.01, Python 3.6.8
See https://gist.github.com/37b1a891e042e88791f94691dd4eff6f for a full test report.

Copy link
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Contributor

Going in, thanks @Micket!

@akesandgren akesandgren merged commit 8942e79 into easybuilders:develop Dec 1, 2021
@Micket Micket deleted the 20211102213733_new_pr_jupyter-matlab-proxy034 branch April 21, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants