-
Notifications
You must be signed in to change notification settings - Fork 772
{math}[GCCcore/10.3.0] jupyter-matlab-proxy v0.3.4 w/ Python 3.9.5 #14270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{math}[GCCcore/10.3.0] jupyter-matlab-proxy v0.3.4 w/ Python 3.9.5 #14270
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@Micket: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/1416302957 bleep, bloop, I'm just a bot (boegelbot v20200716.01) |
|
Updated based on zoom disucssion. Dropped matlab, replaced with a message. Also add patch for using EB installed matlab license by default. |
|
@boegelbot please test @ generoso |
|
@Micket: Request for testing this PR well received on login1 PR test command '
Test results coming soon (I hope)... - notification for comment with ID 980087222 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @Micket |
|
Test report by @boegelbot |
|
Test report by @SebastianAchilles |
SebastianAchilles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
akesandgren
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Going in, thanks @Micket! |
(created using
eb --new-pr)Big problem remains: We had MATLAB's runtime libs conflict with our stuff, in particular, npm is broken here.
We should look into whether or not we need to add all those paths to LD_LIBRARY_PATH in MATLAB, I don't think they are actually necessary in most usecases.