Skip to content

avoid using system GTK+3 and remove -DCMAKE_BUILD_TYPE=RELEASE configure option in OpenCV easyconfigs #13621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
boegel merged 1 commit into from
Sep 5, 2021
Merged

avoid using system GTK+3 and remove -DCMAKE_BUILD_TYPE=RELEASE configure option in OpenCV easyconfigs #13621

boegel merged 1 commit into from
Sep 5, 2021

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Aug 5, 2021

(created using eb --new-pr)

@Flamefire Flamefire mentioned this pull request Aug 5, 2021
Merged
12 tasks
@Flamefire
Copy link
Contributor Author

Flamefire commented Aug 5, 2021

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
taurusi6606.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/72bfd89f782b31d3162c3f5558987106 for a full test report.

@branfosj branfosj added this to the 4.x milestone Aug 5, 2021
Micket
Micket approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Contributor

Micket commented Sep 3, 2021 •
edited
Loading

Test report by @Micket
xxx FAILED xxx (dismissing the failure, it's just because this old stuff is just so.. broken)
Build succeeded for 18 out of 28 (4 easyconfigs in total)
alvis-c1 - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake), Python 3.6.8
See https://gist.github.com/499162ef651bf2fb6d36e632c4ba37b9 for a full test report.

@boegel boegel changed the title OpenCV: Avoid using system GTK+3 and remove CMAKE_BUILD_TYPE avoid using system GTK+3 and remove CMAKE_BUILD_TYPE in OpenCV easyconfigs Sep 4, 2021
@boegel boegel changed the title avoid using system GTK+3 and remove CMAKE_BUILD_TYPE in OpenCV easyconfigs avoid using system GTK+3 and remove -DCMAKE_BUILD_TYPE=RELEASE configure option in OpenCV easyconfigs Sep 4, 2021
@boegel
Copy link
Member

boegel commented Sep 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
node2625.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/566c50facd60082f2728e785c5be3acb for a full test report.

@boegel boegel modified the milestones: 4.x, 4.4.2 Sep 5, 2021
@boegel
Copy link
Member

boegel commented Sep 5, 2021

Going in, thanks @Flamefire!

@boegel boegel merged commit ab90495 into easybuilders:develop Sep 5, 2021
@boegel
Copy link
Member

boegel commented Sep 5, 2021

Test report by @boegel
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in total)
node3131.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/4c2e2a6249d3ebc498d97ab0f0b090d1 for a full test report.

@Flamefire Flamefire deleted the 20210805110400_new_pr_OpenCV2412 branch September 14, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

code cleanup

Projects

None yet

Milestone

4.4.2

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @Micket @boegel @branfosj