fix build of DIRAC 19.0 easyconfig with high compiler optimizations #13613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2021
boegel
changed the title
Member
|
@boegelbot please test @ generoso |
Collaborator
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 893341772 processed Message to humans: this is just bookkeeping information for me, |
Contributor
Author
|
Test report by @Flamefire |
Member
|
Test report by @boegel |
Collaborator
|
Test report by @boegelbot |
Member
|
Test report by @boegel |
Member
|
Test report by @boegel |
Contributor
Author
|
@boegel The failure looks like some unrelated issue with UCX? |
Member
Yeah, I'm a bit puzzled what's going on there, but looks unrelated, so I won't let it block this PR. For reference, some DIRAC tests are failing on Intel Skylake for DetailsDetailsPerhaps related to #13628 ? |
Member
|
Going in, thanks @Flamefire! |
Contributor
|
Doesn't look related at first sight. You never know but this seems more of a UCX vs lower level network libraries/driver issue. |
Member
|
It's indeed an unrelated issue, problem remains even after rebuilding GCCcore and UCX using the patch from #13628 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)This is basically a fixed version of #13455 which I initially created because with
--default-opt-level=optone of the tests of the MPI build failed.The crucial part here is that
set(CMAKE_Fortran_FLAGS_RELEASE "-O3 -ip")needs the-ipoption so the tests succeed, otherwise a misoptimization seemingly occurs.So I changed the
DIRAC-19.0_use_easybuild_opts.patchwhich is meant to make the build use the CMake options and remove stuff like unconditional-g. So changes now:set(CMAKE_C_FLAGS_DEBUG "-O0")fully removed --> Don't inject an optimization option for (here: DEBUG) configsset(CMAKE_C_FLAGS_RELEASE "-O2 -Wno-unused")--> Moved the warning flag to CMAKE_C_FLAGS and removed the restset(CMAKE_CXX_FLAGS_DEBUG "-O0 -DDEBUG")->set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -DDEBUG")--> Remove the -O0, keep the default flags and the custom defineset(CMAKE_Fortran_FLAGS_RELEASE "-O3 -ip")->set(CMAKE_Fortran_FLAGS_RELEASE "${CMAKE_Fortran_FLAGS_RELEASE} -ip")similar, keep the-ip!In the EC I removed CMAKE_BUILD_TYPE, separate_build_dir,
-Gas those are the defaults alreadyI also checked if we can remove the
parallel = 1and do have an idea but that change would be to large and the build "only" takes about 20min (could be cut down to 2-4 with awhile ! make -jloop... but yeah)@hajgato