Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Jun 8, 2021

(created using eb --new-pr)

@boegel boegel added the new label Jun 8, 2021
@boegelbot
Copy link
Collaborator

@boegel: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/919128383
Output from first failing test suite run:

ERROR: test__parse_easyconfig_ROCm-4.2.0-GCC-10.3.0-amd.eb (test.easyconfigs.easyconfigs.EasyConfigTest)
Test for easyconfig ROCm-4.2.0-GCC-10.3.0-amd.eb
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 1255, in innertest
    template_easyconfig_test(self, spec_path)
  File "test/easyconfigs/easyconfigs.py", line 1054, in template_easyconfig_test
    app = app_class(ec)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/easyblocks/generic/bundle.py", line 67, in __init__
    super(Bundle, self).__init__(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyblock.py", line 259, in __init__
    self.group = use_group(group_name)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/systemtools.py", line 968, in use_group
    raise EasyBuildError(err_msg)
EasyBuildError: "Failed to use group ('video', 44): [Errno 1] Operation not permitted; current user 'runner' is not in group ('video', 44) (members: ['runneradmin'])"

======================================================================
ERROR: test_changed_files_pull_request (test.easyconfigs.easyconfigs.EasyConfigTest)
Specific checks only done for the (easyconfig) files that were changed in a pull request.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/easyconfigs.py", line 990, in test_changed_files_pull_request
    self.check_sha256_checksums(changed_ecs)
  File "test/easyconfigs/easyconfigs.py", line 691, in check_sha256_checksums
    checksum_issues = check_sha256_checksums(retained_changed_ecs, whitelist=whitelist)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyconfig/tools.py", line 653, in check_sha256_checksums
    checksum_issues.extend(eb_class(ec).check_checksums())
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/easyblocks/generic/bundle.py", line 67, in __init__
    super(Bundle, self).__init__(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/framework/easyblock.py", line 259, in __init__
    self.group = use_group(group_name)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/easybuild/tools/systemtools.py", line 968, in use_group
    raise EasyBuildError(err_msg)
EasyBuildError: "Failed to use group ('video', 44): [Errno 1] Operation not permitted; current user 'runner' is not in group ('video', 44) (members: ['runneradmin'])"

======================================================================
FAIL: test_style_conformance (test.easyconfigs.styletests.StyleTest)
Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/easyconfigs/styletests.py", line 57, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 1

----------------------------------------------------------------------
Ran 12353 tests in 429.471s

FAILED (failures=1, errors=2)
ERROR: Not all tests were successful.

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice you me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@boegel boegel mentioned this pull request Jun 8, 2021
5 tasks
@boegel boegel added this to the 4.x milestone Jun 8, 2021
# cfr. https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html
group = 'video'

local_llvm_configopts = "-DCLANG_OPENMP_NVPTX_DEFAULT_ARCH=sm_70 -DLIBOMPTARGET_NVPTX_COMPUTE_CAPABILITIES=70 "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required for this EasyConfig? I think that until AMD combines AOMP into their "upstream" fork of LLVM, the version of LLVM built by this EC can't do AMD offloading. It then doesn't make that much sense to enable offloading to Nvidia. I'm asking because if we want to support Nvidia here we probably need an EasyBlock to handle --cuda-compute-capabilities

@boegel
Copy link
Member Author

boegel commented Dec 27, 2021

Superseded by #14355, so closing...

@boegel boegel closed this Dec 27, 2021
@boegel boegel deleted the 20210608192539_new_pr_ROCm420 branch December 27, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants