Skip to content

Conversation

@Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Mar 23, 2021

(created using eb --new-pr)

We should always use pip to avoid problems.
Often there is a generic wheel package available. Those are named '%(name)s-%(version)s-py2.py3-none-any.whl'
The naming means, that the package is not build at all but simply a packaged source distribution. The source.tar.gz may not be usable at all, as it might be missing the version, which gets filled in by tox out of the git tag when done in version control, but NOT for the PyPI download. A recent example is keyring which after installation showed up as keyring-0.0.0

This PR also fixes an actual bug: Installing poetry in the EC is not only superflous, it is also missing its dependencies so it could not be used at all and will make future pip checks fail. This was likely the reason for the comment: Using pip install led to actual use of poetry which failed due to missing dependencies while the setup.py circumvented the problem "somehow"

Possible follow-ups:

  • In the sanity check do something like pip list and check for the package and that it's version is not 0.0.0
  • Add '%(name)s-%(version)s-py2.py3-none-any.whl' (+ py2, py3 versions) to templates

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
taurusa4 - Linux centos linux 7.7.1908, x86_64, Intel(R) Xeon(R) CPU E5-2603 v4 @ 1.70GHz (broadwell), Python 2.7.5
See https://gist.github.com/4f4b77b5a22f93208c8b94d225b6e458 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
FAILED
Build succeeded for 4 out of 5 (4 easyconfigs in total)
taurusml7 - Linux RHEL 7.6, POWER, 8335-GTX (power9le), Python 2.7.5
See https://gist.github.com/84e706abd0e647401bbc3b4b1edd2c17 for a full test report.

@boegel
Copy link
Member

boegel commented Mar 23, 2021

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=12455 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_12455 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 16416

Test results coming soon (I hope)...

Details

- notification for comment with ID 805217707 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
generoso-c1-s-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/8fe5331f2f3f5a3dc89a2334537fe99f for a full test report.

@boegel
Copy link
Member

boegel commented Mar 23, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3507.doduo.os - Linux RHEL 8.2, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/d55ae68d7b4c953157037c5eee68bd3f for a full test report.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Mar 23, 2021

Going in, thanks @Flamefire!

@boegel boegel merged commit 57e008d into easybuilders:develop Mar 23, 2021
@boegel
Copy link
Member

boegel commented Mar 23, 2021

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3107.skitty.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/6a2bf3c0cbb5f86e6cfe59bcbd111ec3 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants