-
Notifications
You must be signed in to change notification settings - Fork 773
Use pip to install pkgconfig 1.5.1 #12455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pip to install pkgconfig 1.5.1 #12455
Conversation
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
@boegelbot please test @ generoso |
|
@boegel: Request for testing this PR well received on generoso PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 805217707 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @boegel |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Going in, thanks @Flamefire! |
|
Test report by @boegel |
(created using
eb --new-pr)We should always use pip to avoid problems.
Often there is a generic wheel package available. Those are named
'%(name)s-%(version)s-py2.py3-none-any.whl'The naming means, that the package is not build at all but simply a packaged source distribution. The source.tar.gz may not be usable at all, as it might be missing the version, which gets filled in by
toxout of the git tag when done in version control, but NOT for the PyPI download. A recent example iskeyringwhich after installation showed up askeyring-0.0.0This PR also fixes an actual bug: Installing poetry in the EC is not only superflous, it is also missing its dependencies so it could not be used at all and will make future
pip checks fail. This was likely the reason for the comment: Usingpip installled to actual use of poetry which failed due to missing dependencies while the setup.py circumvented the problem "somehow"Possible follow-ups:
pip listand check for the package and that it's version is not0.0.0'%(name)s-%(version)s-py2.py3-none-any.whl'(+ py2, py3 versions) to templates