Skip to content

Conversation

@migueldiascosta
Copy link
Member

@migueldiascosta migueldiascosta commented Sep 17, 2020

(created using eb --new-pr)

noticed that there isn't an intel/2019b easyconfig - this one is basically the foss/2019b one with the intel specific extension patches from intel/2019a, seems to work, but I may be missing something

@migueldiascosta
Copy link
Member Author

I suppose the ppc patch is irrelevant here, but I'll wait for further feedback

@migueldiascosta
Copy link
Member Author

Test report by @migueldiascosta
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
sms - Linux centos linux 7.6.1810, x86_64, AMD EPYC 7601 32-Core Processor (zen), Python 2.7.5
See https://gist.github.com/1b0b101a130148b6845c7c6579a3c6e2 for a full test report.

@boegel boegel modified the milestones: 4.x, next release (4.3.1) Sep 17, 2020
@boegel
Copy link
Member

boegel commented Sep 17, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11298 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11298 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7828

Test results coming soon (I hope)...

- notification for comment with ID 694436193 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in this PR)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/24a3ff16383b1ef8fa0dc94f5bd31ee0 for a full test report.

boegel
boegel previously approved these changes Sep 17, 2020
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after visual review

@boegel
Copy link
Member

boegel commented Sep 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3153.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/93af5b9cd9da13f3376d15538aeac204 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2405.golett.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/605be5cc2bc0a4f4cc39440ce3a77748 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 18, 2020

Problem on CentOS 8:

arithmetic.c(61): warning #274: declaration is not visible outside of function
  int matherr(struct exception *exc)
                     ^

arithmetic.c(63): error: pointer to incomplete class type is not allowed
      switch (exc->type) {
              ^

arithmetic.c(64): error: identifier "DOMAIN" is undefined
      case DOMAIN:
           ^

arithmetic.c(65): error: identifier "SING" is undefined
      case SING:
           ^

arithmetic.c(68): error: identifier "OVERFLOW" is undefined
      case OVERFLOW:
           ^

arithmetic.c(71): error: identifier "UNDERFLOW" is undefined
      case UNDERFLOW:
           ^

see https://community.intel.com/t5/Intel-C-Compiler/Error-when-compiling-R-from-source-code-ubuntu-18-04/td-p/1176401

@boegel
Copy link
Member

boegel commented Sep 18, 2020

I'm working on a (proper) patch to fix the CentOS 8 issue, that should not cause trouble on older OS versions...

edit: see migueldiascosta#31

… (+ remove patch file that only makes sense on POWER)
add patch for R 3.6.2 with intel/2019b to fix compilation on CentOS 8
@migueldiascosta
Copy link
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@migueldiascosta: Request for testing this PR well received on generoso

PR test command 'EB_PR=11298 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11298 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7830

Test results coming soon (I hope)...

- notification for comment with ID 694776552 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/c884519b6183c7f8c8e76284dda73a50 for a full test report.

@boegel
Copy link
Member

boegel commented Sep 18, 2020

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node3123.skitty.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/de53462c33d319ca6dac36d40f5c0e8a for a full test report.

@boegel
Copy link
Member

boegel commented Sep 19, 2020

Going in, thanks @migueldiascosta!

@boegel boegel merged commit 5394103 into easybuilders:develop Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants