Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Sep 2, 2020

(created using eb --new-pr)

@boegel boegel added the update label Sep 2, 2020
@boegel boegel added this to the next release (4.3.0) milestone Sep 2, 2020
@boegel
Copy link
Member Author

boegel commented Sep 2, 2020

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11201 EB_ARGS= /apps/slurm/default/bin/sbatch --job-name test_PR_11201 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5220

Test results coming soon (I hope)...

- notification for comment with ID 685975339 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Member Author

boegel commented Sep 2, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node3405.kirlia.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz (cascadelake), Python 2.7.5
See https://gist.github.com/9a74fd38346a7fb082e4f3f0a68ad94c for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso-x-5 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/3fcbec95ddefe88640dc00f8bc564c0d for a full test report.

@boegel
Copy link
Member Author

boegel commented Sep 2, 2020

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
node2609.swalot.os - Linux centos linux 7.8.2003, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 2.7.5
See https://gist.github.com/c6674738c4420cb0fcdbe345f47b70bf for a full test report.

@boegel boegel requested a review from smoors September 3, 2020 07:28
smoors
smoors previously requested changes Sep 3, 2020
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel lots of wrong urls here

@verdurin
Copy link
Member

verdurin commented Sep 8, 2020

@boegel could you look at the suggested changes please?

@boegel
Copy link
Member Author

boegel commented Sep 8, 2020

@verdurin done in e32ab31

@boegel
Copy link
Member Author

boegel commented Sep 8, 2020

@boegelbot please test @ generoso
EB_ARGS="--force-download --download-timeout 3600 --sourcepath /tmp/$USER/pr11201"

@easybuilders easybuilders deleted a comment from boegelbot Sep 8, 2020
@easybuilders easybuilders deleted a comment from boegelbot Sep 8, 2020
@boegelbot
Copy link
Collaborator

@boegel: Request for testing this PR well received on generoso

PR test command 'EB_PR=11201 EB_ARGS="--force-download --download-timeout 3600 --sourcepath /tmp/$USER/pr11201" /apps/slurm/default/bin/sbatch --job-name test_PR_11201 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5269

Test results coming soon (I hope)...

- notification for comment with ID 688734305 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in this PR)
generoso-x-1 - Linux centos linux 8.2.2004, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/a3bbea09ee6d84dd53426ef53a9d65e1 for a full test report.

@verdurin
Copy link
Member

verdurin commented Sep 8, 2020

Test report by @verdurin
SUCCESS
Build succeeded for 13 out of 13 (4 easyconfigs in this PR)
nuc.lan - Linux Fedora 32, x86_64, Intel(R) Core(TM) i7-8650U CPU @ 1.90GHz, Python 3.8.5
See https://gist.github.com/aeeadc21f396453489ad0ce305720be0 for a full test report.

Copy link
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Member

verdurin commented Sep 9, 2020

@smoors are you content with the changes now?

@boegel
Copy link
Member Author

boegel commented Sep 9, 2020

@verdurin The changes were necessary to make downloading work, that's 100% fixed now (see how boegelbot tested this PR).

@verdurin verdurin dismissed smoors’s stale review September 9, 2020 11:19

Requested changes have been applied.

@verdurin
Copy link
Member

verdurin commented Sep 9, 2020

Going in, thanks @boegel!

@verdurin verdurin merged commit 82eb590 into easybuilders:develop Sep 9, 2020
@boegel boegel deleted the 20200902222113_new_pr_Perl5320 branch September 9, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants