Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Dec 12, 2015

No description provided.

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1485/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1486/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1487/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Member

lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wpoely86: doing this fixes this issue for me, based on the info in https://software.intel.com/en-us/forums/intel-c-compiler/topic/338378

lib/types.h(107): error: qualified name is not allowed                                                                                                                         
    typedef std::complex<double> cdouble;                                                                                                                                      
...                                                                                                                    
lib/types.h(107): error: expected a ";"                                                                                                                                        
    typedef std::complex<double> cdouble;  

It feels like a workaround for a bug though... Are we doing something wrong with $CPATH somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problem was caused by having include subdir of icc included in $CPATH

fixed with wpoely86#20 (included in #756)

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1494/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1495/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Dec 14, 2015

Jenkins: test this please

@boegel
Copy link
Member Author

boegel commented Dec 14, 2015

Jenkins: ok to test

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1501/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member Author

boegel commented Dec 14, 2015

tested thoroughly with easybuilders/easybuild-easyconfigs#2217 and easybuilders/easybuild-easyconfigs#2218, good to go, thanks for the review @wpoely86!

boegel added a commit that referenced this pull request Dec 14, 2015
add easyblock for MRtrix
@boegel boegel merged commit 01cf4bc into easybuilders:develop Dec 14, 2015
@boegel boegel deleted the mrtrix branch December 14, 2015 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants