Skip to content

Conversation

@jas02
Copy link
Contributor

@jas02 jas02 commented Nov 20, 2015

Fixes the problem with wrong directory checking. There's no mkl/bin/intel64 anymore.

@hpcugentbot
Copy link

Automatic reply from Jenkins: Can I test this?

@boegel
Copy link
Member

boegel commented Nov 21, 2015

Jenkins: ok to test

@boegel boegel added this to the v2.5.0 milestone Nov 21, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should only remove the check on mkl/bin/intel64 for the newest versions of imkl, and also check what kind of potential fallout this has (which tools are located in mkl/bin/intel, and where are they used by EB)?

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1372/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@wpoely86
Copy link
Member

wpoely86 commented Dec 2, 2015

@jas02 please add yourself to the author list. I will pull in your commit.

@jas02
Copy link
Contributor Author

jas02 commented Dec 3, 2015

@wpoely86 Done, thanks.

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1423/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@boegel
Copy link
Member

boegel commented Dec 11, 2015

will get merged via #756

@boegel
Copy link
Member

boegel commented Dec 14, 2015

@jas02: can you sync this with develop? it should render this PR empty, since all changes are included in #756, but I want to double check that...

@jas02
Copy link
Contributor Author

jas02 commented Dec 15, 2015

Seems to be clean.

@hpcugentbot
Copy link

Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1519/console for more details).

This pull request is now ready for review/testing.

Please try and find someone who can tackle this; contact @boegel if you're not sure what to do.

@jas02 jas02 closed this Dec 15, 2015
@boegel
Copy link
Member

boegel commented Dec 15, 2015

Just to confirm: all these changes are already in develop, GitHub is not showing the correct diff for some reason...

@jas02
Copy link
Contributor Author

jas02 commented Dec 15, 2015

I just manually checked, that changes from #745 are already merged in develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants