-
Notifications
You must be signed in to change notification settings - Fork 306
Create lockfile for Cargo package if missing #3995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Create lockfile for Cargo package if missing #3995
Conversation
de3fe7d to
66b2862
Compare
|
@Flamefire This will need to be re-worked on top of: |
|
Shall I wait until that is merged and rebase then? |
Yes, makes sense. |
|
@Flamefire #4016 is merged... |
66b2862 to
a0c5b67
Compare
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3657191421 processed Message to humans: this is just bookkeeping information for me, |
|
@Flamefire Looks like Build step fails with: |
|
There's also trouble with other easyconfigs: For For @Flamefire It seems like this needs more work, so this won't make it in for EasyBuild v5.2.0... |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 19 out of 36 (total: 1 hour 5 mins 29 secs) (36 easyconfigs in total) |
Those errors are real, somehow. They only get detected through the recent change in #3993, prior to that the crates specified in those easyconfigs are silently ignored unless there is something happening that I'm missing. So that needs to be fixed first.
That is weird. Then I'll need to recheck which cargo version has which lockfile version |
…f CargoPythonBundle
We cannot have multiple sources for extensions, see easybuilders/easybuild-framework#3463
806ad6d to
3f95cfa
Compare
That does additional configuration required for Rust crates
a13f9bf to
d491dee
Compare
Found it: Versions 1 and 2 were internal versions only, not reflected in the lockfile, so Also fixed an issue where I started a job with 40 random easyconfigs using Rust as a dependency and the ECs you used above. That will take a while but should succeed now. |
|
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 62 out of 69 (total: 19 hours 9 mins 11 secs) (75 easyconfigs in total) |
(created using
eb --new-pr)Requires/Includes for easier testing:
Cargoeasyblock to mergeCargo.tomlfile with workspace file #4016PythonPackageandCargoconfigure step inCargoPythonPackageeasyblock #3996CargoPythonPackagethe default class for extensions/components ofCargoPythonBundle#3993