-
Notifications
You must be signed in to change notification settings - Fork 304
honor preconfigopts, buildopts and pretestopts in HPCG easyblock
#3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
preconfigopts, buildopts and pretestopts in HPCG easyblock
|
@boegelbot please test @ jsc-zen3 |
|
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 3553358229 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (total: 1 min 27 secs) (2 easyconfigs in total) |
|
Tests with |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided suggestions are "on sight", I didn't test those myself, but I hope it's clear that what's proposed is a lot more readable...
Co-authored-by: Kenneth Hoste <[email protected]>
Co-authored-by: Kenneth Hoste <[email protected]>
Co-authored-by: Kenneth Hoste <[email protected]>
(created using
eb --new-pr)Also fixes a small issue where the
cmd.shwouldn't find the correct directory, therefore not placing a user in the build directory where the command was executed.