-
Notifications
You must be signed in to change notification settings - Fork 305
fix custom easyblock for bzip2 to ensure all versioned symlinks are created #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix custom easyblock for bzip2 to ensure all versioned symlinks are created #3948
Conversation
Thyre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise, just needs some tests 😄
| def sanity_check_step(self): | ||
| """Custom sanity check for bzip2.""" | ||
| libs = ['lib/libbz2.a'] | ||
| if self.cfg['with_shared_libs']: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a sanity check for the unversioned symlinks as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already done, we're already checking for lib/libbz2.so
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) Before: After: |
|
Test report by @Thyre Overview of tested easyconfigs (in order)
Build succeeded for 6 out of 6 (4 easyconfigs in total) |
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
got some software explicitly linking
libbz.so.1, the symlink for which we don't create (so it ended up using the OS bzip2 instead)(created using
eb --new-pr)