-
Notifications
You must be signed in to change notification settings - Fork 308
Changes to LLVM easyblock required for LLVM 21 #3902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
910d7fd to
d0d7590
Compare
d0d7590 to
e36597d
Compare
bartoldeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also need this change:
--- llvm.py.1 2025-11-11 18:57:04.979489101 +0000
+++ llvm.py 2025-11-11 18:58:56.322052977 +0000
@@ -1103,7 +1103,7 @@
opts = [f'--gcc-install-dir={self.gcc_prefix}']
if self.dynamic_linker:
- opts.append(f'-Wl,-dynamic-linker,{self.dynamic_linker}')
+ opts.append(f'-Wl,-dynamic-linker={self.dynamic_linker}')
# The --dyld-prefix flag exists, but beside being poorly documented it is also not supported by flang
# https://reviews.llvm.org/D851
# prefix = self.sysroot.rstrip('/')
otherwise clang-nvlink-wrapper complains.
…so with a bootstrap build and perform the filtering only if `flang` is being built
…hrough `test_suite_include_benchmarks` config parameter - If benchmarks are `OFF` ensure they are also not ran for the runtimes
e36597d to
6609eb3
Compare
…INCLUDE_BENCHMARKS` together with `LLVM_INCLUDE_BENCHMARKS`
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3719706977 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (total: 6 hours 8 mins 24 secs) (4 easyconfigs in total) |
Changes
flangargs fromFFLAGSandF90FLAGSas now flang is used to compile some.modfilesFixes error of the type
flang-21: error: unknown argument: '-fno-math-errno'during the build steptest_suite_include_benchmarksto allow including/excluding benchmarks in the test-suiteWIP
LLVM_INCLUDE_BENCHMARKSis set both for the projects and runtimes buildsmake check-allFailing tests on building 21.1.0-rc2 llvm/llvm-project#151972 (comment)