remove duplicated output of test command from PythonPackage easyblock
#3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`run_shell_cmd` already outputs the stderr/stdout and exit code even with `fail_on_error=False` So don't print it again in PythonPackage which might add huge amounts of text to the log for e.g. the PyTorch tests.
boegel
changed the title
PythonPackage easyblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_shell_cmdalready outputs the stderr/stdout and exit code even withfail_on_error=FalseSo don't print it again in PythonPackage which might add huge amounts of text to the log for e.g. the PyTorch tests.