clean up easyblocks to let CMakeMake they derive from set cmake option to specify Python paths
#3694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flamefire
force-pushed
the
python-cmake-paths
branch
from
74ed31c to
ef8e9ec
Compare
Flamefire
force-pushed
the
python-cmake-paths
branch
from
ef8e9ec to
16c45c6
Compare
Flamefire
force-pushed
the
python-cmake-paths
branch
from
16c45c6 to
eaafb26
Compare
boegel
changed the title
CMakeMake they derive from set cmake option to specify Python paths
When Python is used the CMakeMake easyblock already adds the required CMake options. As it has better logic to do so remove it from derived easyblocks.
Flamefire
force-pushed
the
python-cmake-paths
branch
from
eaafb26 to
8d93a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Python is used the CMakeMake easyblock already adds the required CMake options. As it has better logic to do so remove it from derived easyblocks.
There are 3 easyblocks (lammps, openbabel, root) that also set
PYTHON_LIBRARYandPYTHON_INCLUDE_DIR. The comment in lammps "older lammps" and "deprecated CMake" hints at FindPythonLibs, i.e.find_package(PythonLibs)where they are indeed required. So I left those there for now.